From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Narendra Joshi Newsgroups: gmane.emacs.devel Subject: vcursor.el: `vcursor-copy-word` and `vcursory-copy-line` not working as expected Date: Tue, 23 Nov 2021 20:30:55 +0100 Message-ID: <87y25emzyo.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6902"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: emacs-devel@gnu.org Cancel-Lock: sha1:RR427pFK4JLNWDvmRUICdhLa70Y= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 23 20:36:45 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpbau-0001cd-Dt for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Nov 2021 20:36:44 +0100 Original-Received: from localhost ([::1]:59930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpbat-0003FC-9p for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Nov 2021 14:36:43 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpbZK-0002MA-5M for emacs-devel@gnu.org; Tue, 23 Nov 2021 14:35:06 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]:55830) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpbZI-0003TC-Gt for emacs-devel@gnu.org; Tue, 23 Nov 2021 14:35:05 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mpbZG-0009cN-Ap for emacs-devel@gnu.org; Tue, 23 Nov 2021 20:35:02 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279967 Archived-At: Hi, I think `vcursor.el` has a bug that causes `point` (the real cursor) to move to where the virtual cursor is whenever `vcursor-copy-{word,line}` are used. We need to wrap the `goto-char` call below in something like `save-excursion`: --8<---------------cut here---------------start------------->8--- 1 file changed, 3 insertions(+), 4 deletions(-) lisp/vcursor.el | 7 +++---- modified lisp/vcursor.el @@ -785,12 +785,11 @@ vcursor-get-char-count This is called by most of the virtual-cursor copying commands to find out how much to copy." - (vcursor-check) (with-current-buffer (overlay-buffer vcursor-overlay) - (let ((start (goto-char (overlay-start vcursor-overlay)))) - (- (progn (apply func args) (point)) start))) - ) + (save-excursion + (let ((start (goto-char (overlay-start vcursor-overlay)))) + (- (progn (apply func args) (point)) start))))) ;; Make sure the virtual cursor is active. Unless arg is non-nil, ;; report an error if it is not. --8<---------------cut here---------------end--------------->8--- Best regards, -- Narendra Joshi