unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Narendra Joshi <narendraj9@gmail.com>
To: emacs-devel@gnu.org
Subject: vcursor.el: `vcursor-copy-word` and `vcursory-copy-line` not working as expected
Date: Tue, 23 Nov 2021 20:30:55 +0100	[thread overview]
Message-ID: <87y25emzyo.fsf@gmail.com> (raw)

Hi,

I think `vcursor.el` has a bug that causes `point` (the real cursor) to
move to where the virtual cursor is whenever `vcursor-copy-{word,line}`
are used. 

We need to wrap the `goto-char` call below in something like
`save-excursion`:

--8<---------------cut here---------------start------------->8---
1 file changed, 3 insertions(+), 4 deletions(-)
lisp/vcursor.el | 7 +++----

modified   lisp/vcursor.el
@@ -785,12 +785,11 @@ vcursor-get-char-count
 
 This is called by most of the virtual-cursor copying commands to find
 out how much to copy."
-
   (vcursor-check)
   (with-current-buffer (overlay-buffer vcursor-overlay)
-    (let ((start (goto-char (overlay-start vcursor-overlay))))
-      (- (progn (apply func args) (point)) start)))
-  )
+    (save-excursion
+      (let ((start (goto-char (overlay-start vcursor-overlay))))
+        (- (progn (apply func args) (point)) start)))))
 
 ;; Make sure the virtual cursor is active.  Unless arg is non-nil,
 ;; report an error if it is not.
--8<---------------cut here---------------end--------------->8---

Best regards,
-- 
Narendra Joshi




             reply	other threads:[~2021-11-23 19:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23 19:30 Narendra Joshi [this message]
2021-11-24 12:27 ` vcursor.el: `vcursor-copy-word` and `vcursory-copy-line` not working as expected Eli Zaretskii
2021-11-24 20:41   ` Narendra Joshi
2021-11-24 16:58 ` Stefan Monnier
2021-11-24 20:07   ` Narendra Joshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y25emzyo.fsf@gmail.com \
    --to=narendraj9@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).