unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stephen Berman <stephen.berman@gmx.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Stefan Kangas <stefankangas@gmail.com>, emacs-devel@gnu.org
Subject: Re: emacs-28 6170c50: Fix regression in help-mode prompt
Date: Tue, 14 Dec 2021 15:01:21 +0100	[thread overview]
Message-ID: <87y24n5lqm.fsf@rub.de> (raw)
In-Reply-To: <83h7bbl4el.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 14 Dec 2021 15:09:06 +0200")

On Tue, 14 Dec 2021 15:09:06 +0200 Eli Zaretskii <eliz@gnu.org> wrote:

>> From: Stefan Kangas <stefankangas@gmail.com>
>> Date: Tue, 14 Dec 2021 03:30:22 -0800
>>
>> eliz@gnu.org (Eli Zaretskii) writes:
>>
>> > diff --git a/lisp/help-macro.el b/lisp/help-macro.el
>> > index 1fa9d82..b3c7e23 100644
>> > --- a/lisp/help-macro.el
>> > +++ b/lisp/help-macro.el
>> > @@ -165,14 +165,18 @@ and then returns."
>> >                     (let ((cursor-in-echo-area t)
>> >                           (overriding-local-map local-map))
>> >                       (setq key (read-key-sequence
>> > -                                (format "Type one of the options listed%s: "
>> > +                                (format "Type one of listed options%s: "
>>
>> Are we sure that this is an improvement?  I find the old text more natural.
>
> I didn't change the text to improve it, I changed it to make it
> shorter.  Because otherwise, when we echo the keys typed by the user,
> they overflow the (default) window width, and that resizes the
> mini-window, which causes an unpleasant effect of scrolling the Help
> window.
>
> If you can suggest a different solution that avoids the resizing,
> please do.

Is this about the *Metahelp* buffer displayed by typing `C-h ?'?  Then I
think it's sufficient to prompt with "Type one of the options%s: ",
since the buffer containing the options is in plain view.

Steve Berman



  reply	other threads:[~2021-12-14 14:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211213135228.14462.36839@vcs0.savannah.gnu.org>
     [not found] ` <20211213135230.17FE620A0A@vcs0.savannah.gnu.org>
2021-12-14 11:30   ` emacs-28 6170c50: Fix regression in help-mode prompt Stefan Kangas
2021-12-14 12:47     ` Colin Baxter 😺
2021-12-14 13:05       ` Stefan Kangas
2021-12-14 14:30         ` Colin Baxter 😺
2021-12-14 13:09     ` Eli Zaretskii
2021-12-14 14:01       ` Stephen Berman [this message]
2021-12-14 14:28         ` Eli Zaretskii
2021-12-14 14:40           ` Stephen Berman
2021-12-14 14:16       ` Stefan Kangas
2021-12-14 14:30         ` Eli Zaretskii
2021-12-14 19:17           ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y24n5lqm.fsf@rub.de \
    --to=stephen.berman@gmx.net \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).