From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 2b97e83cc1 2/2: Fix off-by-one file size formatting in ls-lisp Date: Mon, 14 Feb 2022 11:48:42 +0100 Message-ID: <87y22dsoz9.fsf@gnus.org> References: <164464970577.18616.16858189491672331595@vcs2.savannah.gnu.org> <20220212070826.4B772C00895@vcs2.savannah.gnu.org> <83y22frjpy.fsf@gnu.org> <83tud3ri2n.fsf@gnu.org> <83r187rhd8.fsf@gnu.org> <83pmnrqo5m.fsf@gnu.org> <87h793yxtm.fsf@gnus.org> <83h793q7r5.fsf@gnu.org> <874k53uen1.fsf@gnus.org> <83ee47q636.fsf@gnu.org> <838ruerika.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36596"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: salutis@me.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Feb 14 11:53:04 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJYye-0009L0-29 for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Feb 2022 11:53:04 +0100 Original-Received: from localhost ([::1]:49308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nJYyc-0006OA-Qe for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Feb 2022 05:53:02 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJYuf-0004R2-6Y for emacs-devel@gnu.org; Mon, 14 Feb 2022 05:48:57 -0500 Original-Received: from [2a01:4f9:2b:f0f::2] (port=52914 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJYuc-00026g-B0; Mon, 14 Feb 2022 05:48:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lvT0VgEExWnO4wbcVGWZFTloRlMKXOv0vM3fFgM7QkA=; b=CKO+IGdHxRksvwbznAMGPOcmsB VRf4az9+qb+yT+hmllkS2863DOUFhZcQmZH3PYcKXgTdDTKI0HGd3QbcOknT+/DZ0OxCa6JKE2gHX yMJJFYF6lY0LGQSXz4PFa/WFATzyN68xMbsGej+Z1mBVm4wOj0Btg39e1r5ek35LL08U=; Original-Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJYuU-00073N-6w; Mon, 14 Feb 2022 11:48:48 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAALVBMVEUzLzBMTDdBPTRn ajqZoDivxTjb5S4PDQ01O0M5SExVWVg7RDlBPUKLlG7///+ItTPNAAAAAWJLR0QOb70wTwAAAAd0 SU1FB+YCDgoeNoC6WfwAAAGDSURBVDjL1ZOxboMwEIYPltDSShyeqi6EN7BM+wLQvkBDnyBh7paV EbaM0C7MFkjJ1oglc6S+QfMutREQkxB16dJDGPF/uv/OJxvgHwS64F5imnUBMOo6J5KjywRvRm1V 1d0pIjqgPyx81UyXMkGZEgyAIHbrQHG0vBbYNowCNp4Alj6e8GtM/gxMzoGRynU5ApIGnJtI3SiW b+2vud423zTjeZ5nqw5c83YOiZDzWFi1QMNuQEYSNzU6YN31xVcqAFz31eNL+4uPOzdkkzfiacof wWeSXGVxCbzYSYkXx+QEkrS4Lb85lABVMXBOy8PXoar4jlcnk3gvS873APtyCNKVKdY1nMU2+6g3 23ykfbPGDaGIA/FevLWNG8bQdgag1igVgyQMFd2Rp88LfUQNVSAvkPYUBjNx1imxVCPhEQSLkHoU iQ2OIhPqhVE0R2SEUeyOrsYIoew5iiKRwBglHUCcIsVHAV4IMp/2G9FRF8B7jcIFC3xU2kIZxIvm oc8s6MEPo/hbI+3QpFIAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjItMDItMTRUMTA6MzA6NTQrMDA6 MDC9rYNHAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTAyLTE0VDEwOjMwOjU0KzAwOjAwzPA7+wAA AABJRU5ErkJggg== X-Now-Playing: Revolver's _Still in a Dream (3)_: "Heaven Sent An Angel" In-Reply-To: <838ruerika.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 13 Feb 2022 15:40:21 +0200") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286243 Archived-At: Eli Zaretskii writes: > So how about the patch below: > > diff --git a/lisp/files.el b/lisp/files.el > index cfa1a59..7e62726 100644 > --- a/lisp/files.el > +++ b/lisp/files.el > @@ -1494,7 +1494,8 @@ file-size-human-readable > (or unit "B")) > (concat prefix unit)))) > (format (if (and (>= (mod file-size 1.0) 0.05) > - (< (mod file-size 1.0) 0.95)) > + (< (mod file-size 1.0) 0.95) > + (< file-size 10)) Possibly, but it's hard to tell... perhaps a better test is whether the printed representation is longer than 6 characters, and then precision should be reduced. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no