Re: master f0ff20be51: * src/emacs.c (main): Improve accuracy of daemon warning message on PGTK.

[Sean Whitton <spwhitton@spwhitton.name>]

[-- Attachment #1: Type: text/plain, Size: 787 bytes --]

Hello,

On Thu 07 Apr 2022 at 08:28am +08, Po Lu wrote:

> Sean Whitton <spwhitton@spwhitton.name> writes:
>
>> Nice idea to avoid referring users to a bug report that doesn't apply to
>> pgtk.  But is there truly "no way to fix this problem" in the pgtk case
>> too?  Is it really that fundamental to the design of GTK3?
>
> Yes, 100%.  GDK just calls `_exit' on an IO error.  You cannot even run
> an atexit handler.
>
> And since we don't have control over Xlib when built with PGTK, there's
> no way to run code before GDK's own IO error handler either.

Thanks.  I'd like to install the attached patch to preempt questions
like mine; any objections?  I still have some stuff in my init.el based
on the hope that this could be fixed; I'll probably remove it now :(

-- 
Sean Whitton

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-src-emacs.c-main-Say-that-the-problem-is-fundamental.patch --]
[-- Type: text/x-diff, Size: 1119 bytes --]

From adecae1728630541286b4a83406e3c863e0c8f4c Mon Sep 17 00:00:00 2001
From: Sean Whitton <spwhitton@spwhitton.name>
Date: Wed, 6 Apr 2022 17:45:55 -0700
Subject: [PATCH] ; * src/emacs.c (main): Say that the problem is fundamental
 to GTK.

---
 src/emacs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/emacs.c b/src/emacs.c
index acb409fcb7..79f4f54f6f 100644
--- a/src/emacs.c
+++ b/src/emacs.c
@@ -1744,8 +1744,8 @@ main (int argc, char **argv)
 #ifdef HAVE_PGTK
       fputs ("Due to a limitation in GTK 3, Emacs built with PGTK will simply exit when a"
 	     "display connection is closed."
-	     "\nThere is no way to fix this problem, so if you want to use Emacs on Wayland"
-	     "on multiple displays and have Emacs survive disconnects, you lose.",
+	     "\nThe limitation is fundamental to GTK on Wayland, so Emacs on Wayland"
+	     "with multiple displays is unlikely ever to be able to survive disconnections.",
 	     stderr);
 #elif defined USE_GTK
       fputs ("\nWarning: due to a long standing Gtk+ bug\nhttps://gitlab.gnome.org/GNOME/gtk/issues/221\n\
-- 
2.30.2