From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: master f2d2fe6fc8: server-execute: Initialize the *scratch* buffer Date: Fri, 06 May 2022 12:28:25 -0700 Message-ID: <87y1zecvfq.fsf@athena.silentflame.com> References: <165162665935.26821.8964921720746152690@vcs2.savannah.gnu.org> <20220504011059.9F667C009A8@vcs2.savannah.gnu.org> <87levhdfeh.fsf@athena.silentflame.com> <87y1zhe5qz.fsf@athena.silentflame.com> <87levhe24h.fsf@athena.silentflame.com> <871qx74or6.fsf@melete.silentflame.com> <86h763ds6l.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14736"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Notmuch/0.36 Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Stefan Monnier , Robert Pluim , emacs-devel@gnu.org, 55257-submitter@debbugs.gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 06 21:29:56 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nn3eD-0003dQ-RE for ged-emacs-devel@m.gmane-mx.org; Fri, 06 May 2022 21:29:55 +0200 Original-Received: from localhost ([::1]:35102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nn3eC-00054x-Eb for ged-emacs-devel@m.gmane-mx.org; Fri, 06 May 2022 15:29:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nn3cr-0004FN-TJ for emacs-devel@gnu.org; Fri, 06 May 2022 15:28:29 -0400 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:39343) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nn3cq-0001It-CU for emacs-devel@gnu.org; Fri, 06 May 2022 15:28:29 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id EBB065C0100; Fri, 6 May 2022 15:28:27 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 06 May 2022 15:28:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1651865307; x=1651951707; bh=KY g8BYDDfY8UOC+jeUMvBEdIWAO7RL8yShboUjYmUb4=; b=SRBwZ/pHD3jcuEqLTL UtoXKNBOL5raB1zMosyEQr2XbxfRVhCm0KEdvqQsO36YfB29ffd7dVGts19J9nxJ qjkgN/EBj3tG7cfuB5RT/LxrELusxJZav14RMZ5dlGNYf2fhcGPcSz2DI00ByO0H Rza1F3o651ejNx1G2kx5yYNYa4Vgj2oKHq1pGvt/9vYCr1S4sZ0HBkXMGDZnTKsP TnAAhvVF8CG1ehtXPxzcQYaX1FoAvpL02jJ2cV1NXp67Wo8FrKjZDx0XVMyONCj/ DOfEN/L1Z49EeGFv1jCqQZ/jU8fpOzQh568G+K+LCI9wu02Y0Z5CQx0JFQz/4eCR PyeA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651865307; x= 1651951707; bh=KYg8BYDDfY8UOC+jeUMvBEdIWAO7RL8yShboUjYmUb4=; b=I k9hDaBbpaDvPCpYokWZ7j/GIsc9+jv3H90qDluCX+9Mui0YTH7D1oFtiV3+/4E5f jdEcTtljB1u7o35LFMxowkSfIKZcgYFsGd3f7II8AMYm2tdu657TPdfBTdu+ysHH 8Y7PKsK1Bz2QhaP21fkHJejRtPBWuC56FnRuUA8s+gJkaVVsyT8RciOO83Ir7Os0 mxU3XA2zr+m9uTbJVNSz7JPTbn6ZS19qfRATD5cGQWmofvgippOoUF06GJpZNpS9 HNRy8zVsx/eSL7WtV2j/jxVLTwpWeJ3fqYZ3SePu6hIhBZkw0HzVYdHcFd9aKQO5 4no0HBYLfJDgmlHx0Hx8w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefgddufeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffgffkfggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpeevuedujeeuveeuveevfedvtdduueekjeevgfeuveeihfek ffehjeegtdehleeivdenucffohhmrghinhepghhnuhdrohhrghenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsphifhhhithhtohhnsehsphif hhhithhtohhnrdhnrghmvg X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 6 May 2022 15:28:27 -0400 (EDT) Original-Received: by athena.silentflame.com (Postfix, from userid 1000) id 820F51C0503; Fri, 6 May 2022 19:28:25 +0000 (UTC) In-Reply-To: <86h763ds6l.fsf@mail.linkov.net> Received-SPF: pass client-ip=66.111.4.28; envelope-from=spwhitton@spwhitton.name; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289339 Archived-At: Hello, On Fri 06 May 2022 at 10:41am +03, Juri Linkov wrote: >> Here's my fix. Haven't quite finished testing each and every call site >> but seemed worth posting it for comments. > > As found in https://debbugs.gnu.org/9054#295 > there is another place that needs get-initial-buffer-create > in switch-to-buffer: > > if (strcmp (SSDATA (BVAR (XBUFFER (buffer), name)), "*scratch*") == 0) > function = find_symbol_value (intern ("initial-major-mode")); Yes I think you're right. I'll add that to my patch, thanks. -- Sean Whitton