Re: [NonGNU] New packages: avy-menu, flyspell-correct and friends

[Jai Flack <jflack@posteo.net>]

Philip Kaludercic <philipk@posteo.net> writes:

> Jai Flack <jflack@posteo.net> writes:
>
>> Hello everyone.
>>
>> I would like to submit the following packages [1,2] for submission to
>> NonGNU ELPA (patches attached).
>>
>>  - avy-menu
>>  
>>  - flyspell-correct
>>  - flyspell-correct-avy-menu
>>  - flyspell-correct-helm
>>  - flyspell-correct-ido
>>  - flyspell-correct-ivy
>>  - flyspell-correct-popup
>
> Could you perhaps briefly explain what these packages do?  Why the need
> for special helm, ido, ivy packages instead of using completing-read?

That would be helpful wouldn't it ;).

 - avy-menu

   I'm requesting avy-menu for completeness because it is a dependency
   flyspell-correct-avy-menu. It will offer selection options in a
   temporary window at the bottom of the screen which are selectable
   using avy.

 - flyspell-correct

   A wrapper around flyspell to make writing interfaces such as the ones
   below easier. It defines an interface for correcting spelling errors
   with flyspell, allowing the interface (method of selecting
   replacements) to be customised by setting
   `flyspell-correct-interface'.

   It defines four functions for the user
   - flyspell-correct-wrapper :: offers corrections for the first
     incorrect word before point, whether it should keep correcting
     words and the traversal direction can be changed with C-u.
   - flyspell-correct-at-point :: offers corrections for word at point
     using the interface.
   - flyspell-correct-previous, flyspell-correct-next :: offers
     corrections for any incorrect word before or after point.

   It fixes a couple issues I have with the current Ispell / flyspell
   interface:
   - Many of the flyspell commands default to showing a GUI menu
   - Many of the flyspell commands like
     `flyspell-correct-word-before-point' won't correct a word too far
     away from point
   - M-x ispell will start from the beginning of the buffer instead of
     at point, possibly many marked words away from the one you
     intended to correct

 - flyspell-correct-avy-menu
 - flyspell-correct-helm
 - flyspell-correct-ido
 - flyspell-correct-ivy
 - flyspell-correct-popup

   These implement a simple `flyspell-correct-interface' for the given
   package postfix.
 

>> [1] https://github.com/mrkkrp/avy-menu
>> [2] https://github.com/d12frosted/flyspell-correct
>>
>> From de3ab4d80895b09b47172140d06cfe02d6b061e8 Mon Sep 17 00:00:00 2001
>> From: Jai Flack <jflack@disroot.org>
>> Date: Mon, 16 May 2022 13:46:39 +1000
>> Subject: [PATCH] * elpa-packages (avy-menu): New package
>>
>> ---
>>  elpa-packages | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/elpa-packages b/elpa-packages
>> index 734584008d..7c1b7128d6 100644
>> --- a/elpa-packages
>> +++ b/elpa-packages
>> @@ -45,6 +45,9 @@
>>   ("autothemer"          :url "https://github.com/jasonm23/autothemer.git"
>>    :readme "readme.md")
>>  
>> + ("avy-menu"		:url "https://github.com/mrkkrp/avy-menu"
>> +  :ignored-files (".github" "default.nix"))
>> +
>>   ("better-jumper"       :url "https://github.com/gilbertw1/better-jumper.git"
>>    :readme "Readme.md"
>>    :ignored-files ("LICENSE"))
>> -- 
>> 2.30.2
>>
>>
>> From 466ab8a0a1e2694b34e74109f7460802b1212a85 Mon Sep 17 00:00:00 2001
>> From: Jai Flack <jflack@disroot.org>
>> Date: Mon, 16 May 2022 13:09:02 +1000
>> Subject: [PATCH] * elpa-packages (flyspell-correct): New package
>>
>> * elpa-packages (flyspell-correct-avy-menu): New package
>> * elpa-packages (flyspell-correct-helm): New package
>> * elpa-packages (flyspell-correct-ido): New package
>> * elpa-packages (flyspell-correct-ivy): New package
>> * elpa-packages (flyspell-correct-popup): New package
>> ---
>>  elpa-packages | 42 ++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 42 insertions(+)
>>
>> diff --git a/elpa-packages b/elpa-packages
>> index 7c1b7128d6..3fa6a7c994 100644
>> --- a/elpa-packages
>> +++ b/elpa-packages
>> @@ -163,6 +163,48 @@
>>   ("flymake-kondor"	:url "https://github.com/turbo-cafe/flymake-kondor"
>>    :ignored-files ("COPYING.txt"))
>>  
>> + ("flyspell-correct"	:url "https://github.com/d12frosted/flyspell-correct"
>> +  :news "CHANGELOG.org"
>> +  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
>> +                  "flyspell-correct-avy-menu.el" "flyspell-correct-helm.el"
>> +                  "flyspell-correct-ido.el" "flyspell-correct-ivy.el"
>> +                  "flyspell-correct-popup.el" "makem.sh"))
>
> These specifications could be simplified if you were to use separate
> branches for each package.

This is not my package. Unless you are suggesting I request this change
from upstream?

>> + ("flyspell-correct-avy-menu"	:url "https://github.com/d12frosted/flyspell-correct"
>> +  :news "CHANGELOG.org"
>> +  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
>> +                  "flyspell-correct-helm.el" "flyspell-correct-ido.el"
>> +                  "flyspell-correct-ivy.el" "flyspell-correct-popup.el"
>> +                  "flyspell-correct.el" "makem.sh"))
>> +
>> + ("flyspell-correct-helm"	:url "https://github.com/d12frosted/flyspell-correct"
>> +  :news "CHANGELOG.org"
>> +  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
>> +                  "flyspell-correct-avy-menu.el" "flyspell-correct-ido.el"
>> +                  "flyspell-correct-ivy.el" "flyspell-correct-popup.el"
>> +                  "flyspell-correct.el" "makem.sh"))
>> +
>> + ("flyspell-correct-ido"	:url "https://github.com/d12frosted/flyspell-correct"
>> +  :news "CHANGELOG.org"
>> +  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
>> +                  "flyspell-correct-avy-menu.el" "flyspell-correct-helm.el"
>> +                  "flyspell-correct-ivy.el" "flyspell-correct-popup.el"
>> +                  "flyspell-correct.el" "makem.sh"))
>> +
>> + ("flyspell-correct-ivy"	:url "https://github.com/d12frosted/flyspell-correct"
>> +  :news "CHANGELOG.org"
>> +  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
>> +                  "flyspell-correct-avy-menu.el" "flyspell-correct-helm.el"
>> +                  "flyspell-correct-ido.el" "flyspell-correct-popup.el"
>> +                  "flyspell-correct.el" "makem.sh"))
>> +
>> + ("flyspell-correct-popup"	:url "https://github.com/d12frosted/flyspell-correct"
>> +  :news "CHANGELOG.org"
>> +  :ignored-files (".github" "images" "test" "Cask" "LICENSE.md" "Makefile"
>> +                  "flyspell-correct-avy-menu.el" "flyspell-correct-helm.el"
>> +                  "flyspell-correct-ido.el" "flyspell-correct-ivy.el"
>> +                  "flyspell-correct.el" "makem.sh"))
>> +
>>   ("forth-mode"          :url "https://github.com/larsbrinkhoff/forth-mode"
>>    :ignored-files ("test" "Makefile" "compile.el"))
>>  
>> -- 
>> 2.30.2

-- 
Thanks,
Jai