unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 40c0124816: Minor improvements to precision scroll interpolation
Date: Sat, 30 Jul 2022 15:03:08 +0800	[thread overview]
Message-ID: <87y1wbkrpv.fsf@yahoo.com> (raw)
In-Reply-To: <8335ej6t0v.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Jul 2022 08:58:40 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> --- a/lisp/pixel-scroll.el
>> +++ b/lisp/pixel-scroll.el
>> @@ -759,6 +759,9 @@ It is a vector of the form [ VELOCITY TIME SIGN ]."
>>    (interactive "e")
>>    (when pixel-scroll-precision-use-momentum
>>      (let ((window (mwheel-event-window event))
>> +          ;; The animations are smoother if the GC threshold is
>> +          ;; reduced for the duration of the animation.
>> +          (gc-cons-threshold (* gc-cons-threshold 3))
>>            (state nil))
>
> I don't think it is safe to multiply gc-cons-threshold without some
> kind of limitation from above: the user or some Lisp program could
> have increased the threshold already to a large value.

Right, I see the problem.



  reply	other threads:[~2022-07-30  7:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-30  5:58 master 40c0124816: Minor improvements to precision scroll interpolation Eli Zaretskii
2022-07-30  7:03 ` Po Lu [this message]
2022-07-30  7:27 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1wbkrpv.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).