From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: undo-auto--undoable-change infloop Date: Wed, 10 Aug 2022 04:39:45 +0200 Message-ID: <87y1vwq0su.fsf@web.de> References: <87o7xc1qbh.fsf@web.de> <831qu8dqrx.fsf@gnu.org> <87bktbciup.fsf@web.de> <875yjfo105.fsf@web.de> <87fsii0vvp.fsf@web.de> <87zgge3vzv.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18126"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 10 04:42:18 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLbfm-0004XD-CW for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Aug 2022 04:42:18 +0200 Original-Received: from localhost ([::1]:38432 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLbfl-00043q-EY for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Aug 2022 22:42:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLbdu-0002KF-71 for emacs-devel@gnu.org; Tue, 09 Aug 2022 22:40:23 -0400 Original-Received: from mout.web.de ([212.227.15.4]:34495) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLbdQ-0002aU-HE; Tue, 09 Aug 2022 22:40:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1660099186; bh=8kMfmUQ8R9Fay5TdXFOh9gXvmcNMUF4xdMBFBGVK5gE=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=JLbuAdoa4pUmizPOcoBDImQsiHWfvpaBd09OVZQjsJqfACTDqtWcKAEbGg+BIPW8a 5a9paRLOOy0CeCmXHOd1a1rdabxePtZl5rhglDRqmcD1sGt3Eix0jGNTXni7j52WOD NJhJ9gezQyH3aLkmrYtUaKeKtOetiGT0BTkPcf2g= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1Mvsln-1nVIIP1dg7-00sYRW; Wed, 10 Aug 2022 04:39:46 +0200 In-Reply-To: (Stefan Monnier's message of "Tue, 09 Aug 2022 04:00:10 -0400") X-Provags-ID: V03:K1:UYq3Vog9wrL4cGRPeAqSaGJ5Ni3aur+Rlv1vGFCPTiFyKqDWcVa kpj0dZYqgoqfNW59o7FJY6Ns9dKYgHpacLHcPVdm+Wf2gblpP5IvN7I6joFj4P9AIdHdQrp HcZCFfMVI496yJteYbFmCrIJcvgoRxjsNq5SDPx3x77rkST60x3Z7OEBfTnbGl77P9XiaWR VlpHpXHN9MA86jB3LNgrw== X-UI-Out-Filterresults: notjunk:1;V03:K0:xVG/jWPsKxE=:gFL1i0e9UWopK5AiRqvMDZ sI5R7sjdtIkyW1mJahQRn/M4+JhQxlt3h9HOGYWZvq7QsefapXGwC4g5pdR2P3i96qwZkiRhp 5ee38yPfJjWxWqBTPuo5E/550+AzgnUyynQ3vjVp4fRHt7fnemAazp/pz6gWuCoVY6cUN20lb HLLkgZ8d0Uo/63zd6fjqzKn1vrydOTCCQS27sFQd5wFekZ6OkK10/dnEr1eTpWv7Ya3mD3Xso kvYPcDGEh2mKyaqNZyDIK0e3mODfduHu1BZxKpcXkMfwct/Jlcyuwt22erSZPLGiDNCiWaqnC GvIQxCGx0GzJdgdoalYxF9975Rlix5Fvz1VIVjRXfx1g5dyM5El3W4l7l3RyLWS9pTIU0Hqhs yeNKXlbQRz14GPDMJ/bH7tEmQZDjmSTigGNFF8+XHsT9rtBd+IK2qlR5S8Ky0guOaxq/LJKri qigtEwP9+uRD/hg2e/7aX9IZIMayhEvHNnzhSWomb6gJLEwOOFAvgbHgkUaCr7uDNvC2BcXIl 6HLWQ6GuAQLa1CXMIAOEa6rx0UyzPwb4oo7LB8dFSslLfOHgy91PSOYKspeUVZOHO42sUbjz2 Pl/3s6ss4PMd52OFKPaxrIVBSddQkOxNHqi5Ms26uNAKkuQCJ8dLGEiqkspjE2qGXdEO2j5p+ 0+MyiJIN00TnadiOFKndXJb4I9x4KjfUN4aCI8dP4pIFYheShm8Fuuevyf4ck6sc+JJbzbmCz spneADjZzBBmf6Bjkr3Mk4TqRSJJrpYzKZ8Z/yWK8GFKNxxHPWQpNj5I5xG08fI5c8aXTnIa Received-SPF: pass client-ip=212.227.15.4; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293339 Archived-At: Stefan Monnier writes: > But I think you can `cancel-timer` before `timer-activate`, which will > make sure it's not in the list any more. That solution also came to my mind. Wastes a lot of time, though. The `timer-list' is traversed 3 times: First, to find the timer to delete it, second to test if it's already present when trying to add it (your change), third, to sort it in at the right position (though I don't understand why that is necessary). The list is probably never that large so that it would matter much. Anyway, thanks for answering and sorry for the noise, Michael.