From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 088171e053 1/2: Fix ns-win.el (x-file-dialog) declaration Date: Fri, 19 Aug 2022 21:29:07 +0800 Message-ID: <87y1vkmkf0.fsf@yahoo.com> References: <166090717426.4526.7562850425788954733@vcs2.savannah.gnu.org> <20220819110614.BB982C04F0E@vcs2.savannah.gnu.org> <8735dso36b.fsf@yahoo.com> <87pmgwv3u0.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34775"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 19 15:34:39 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oP290-0008ov-Ov for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Aug 2022 15:34:38 +0200 Original-Received: from localhost ([::1]:51082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oP28z-0003yH-B4 for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Aug 2022 09:34:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50880) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oP23s-0005zJ-5Z for emacs-devel@gnu.org; Fri, 19 Aug 2022 09:29:20 -0400 Original-Received: from sonic305-21.consmr.mail.ne1.yahoo.com ([66.163.185.147]:34279) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oP23p-00023O-Pv for emacs-devel@gnu.org; Fri, 19 Aug 2022 09:29:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1660915755; bh=otBWn6k0T+5fN1IdwHe4TjKWDpyqyex4CTm/bNgWERQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=kOf1GMIyVx1XvbLljJ+wy07R0RDejwuIWLJCUtRVkretag5pPEGfaQ+rC1guCKISobU93GQBEj39eNnJd6p/TdQ4lu9I6LkXdASUCoahROqS3SOu4rzrGJV2I78ZIF8Zkfnx/weCfKNrZvhqAB3vOw6dkHY0sUVb5CuI2A3T0zASTzYnXNKkY5seN3SKkimSqUPgCKWCdRx9SI3i01QKBiL8YENeRh+QCVo2zHa6qJqytDHuL8ch+w0jPE7DXNyOG5QokXA+BIyL54M84RTCwgQoJHqT7ySnxhpJsgR5+P5XjMsNj+hv5LM3IAg6peHMKpnEbnyhmhQnYStPOeBcyg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1660915755; bh=S4SsQNzzb7VV6ZQ4vPtAO7IVIIIaCd2NYv9TxptHhxa=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=ndkMQK1LVwX0f9stUKRTPhv/OuWPZlTd691UIPuAGm3yvVhaQ5c85F3IoLQHyF9IbpcrRHoXP57AwtF1fFvHNM+0d+5myv1WYX8K5rIr4QcmM3Y8+8Ile3BSdeJpeb9/ud11ZNfBEb75O29lb4/HUkLiAa0lq6UYVczzrKvuxIyuV0FKym8dApadbvtjuemQFC7+gwnzr80C0wolkivtQwUy0fJ+7/hhhSSRp3GOF8J9Im0bQb9nhxL4NFG4Iws1i4LMWtfTBchngeKyNRg69Oj2g8Un7QnkBtm6j81DutdoE8b+/6nI8AUn4I/PahGVLzpUHh6XPMoCUEekckStZQ== X-YMail-OSG: dYBFsGsVM1nhI3mRwAPWXCEKRO2R.aJqbnLV48kRvEByUHi5VeEd400st11RDej YCqBRwK2x7VIRQwPevjg039e9vGl_xYGfEELuBRdXHdZ6sWerLJIF5k.dtjuzU0j9V7JvRO.VVrn B3QuNrEMG_1MtcxWgFgi_MV_reRXsCrUt7H_PYv2TObBIz0CZ46uILOnV0to9OG10N0sMtDFwhIA gtX_nsYWBkc.gmzL5EkYFQmSkrKGeWgGeAJqUIIYBwG5hwEL3JF4Q95e7yxiRIo.TlxewmSG4.6D sFZixM2Jgv_0QNg1knUyiRoJeJIaM5bn2KvgYaJRsOtLHe4tjo3HoD17dqdc8LN.DQ0JS9jQS5bx erRCCZ8Qn3wdNnRD3ahzGXB3knUHGtmtZH5tdC9ZDHPOsqqxn9iNM7ZDkQjx2acwyOgAJ8BOocaF GDpXWmiHsu.ZxuCzxjxSkRzNvIw.yhryppNkJ6JgKaEEr9Xizam3gpOJw4wQpbKjxsK5L1kr_4jw 3vOCe8JQusht4sIv9zBCmuhT1NoVQ_fHYlXbipse_DW7Bs0kaULi_72DoffkHWAJ4ZQ1_UOO4e86 68oo.YhPqnDIra8kaNs.rOyAFDe9DmHFit38cQTThxTbN1JzwRTq.GJ4AVU2.Vb3pJKWI9aWKT2s 7D.vgEMc7WFh9SCHIlcAhWqBSnJcKr07zXox_kq2ZFYjT5gZPPhn4h.MuiDGmN1afJxqwLw4W2aW d9PREkwT_wFK8UBzsNOsnhdPQ7giomY.fzglFkLND8q3vxWgadHnugC_oT9PS_qZ4KCW0mjVfg38 m1gaS8z.wTk93I391eZNCrRdLWsmzYKmEBs8IBzXhj X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ne1.yahoo.com with HTTP; Fri, 19 Aug 2022 13:29:15 +0000 Original-Received: by hermes--canary-production-sg3-6f58cd9b5-pcmsn (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 267fd71fcb33b2556347ff3cd943a7f4; Fri, 19 Aug 2022 13:29:12 +0000 (UTC) In-Reply-To: <87pmgwv3u0.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 19 Aug 2022 14:02:31 +0200") X-Mailer: WebService/1.1.20560 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.185.147; envelope-from=luangruo@yahoo.com; helo=sonic305-21.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293635 Archived-At: Lars Ingebrigtsen writes: > Po Lu writes: > >> I guess it would be good to change the function arguments names too to >> avoid the underscores. > > Yup. Could you please do that? I will probably be preoccupied for the next several days. Thanks.