Re: master 088171e053 1/2: Fix ns-win.el (x-file-dialog) declaration

Re: master 088171e053 1/2: Fix ns-win.el (x-file-dialog) declaration

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> branch: master
> commit 088171e05316c9188186a731f3c7e68c103c4e0a
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
>     Fix ns-win.el (x-file-dialog) declaration
>     
>     * lisp/term/ns-win.el (x-file-dialog): Give the function the same
>     signature here as other definitions.
> ---
>  lisp/term/ns-win.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/term/ns-win.el b/lisp/term/ns-win.el
> index e26191b33b..56aca2bd83 100644
> --- a/lisp/term/ns-win.el
> +++ b/lisp/term/ns-win.el
> @@ -439,7 +439,8 @@ Lines are highlighted according to `ns-input-line'."
>  
>  ;;;; File handling.
>  
> -(defun x-file-dialog (prompt dir default_filename mustmatch only_dir_p)
> +(defun x-file-dialog (prompt dir &optional default_filename
> +                             mustmatch only_dir_p)
>    "SKIP: real doc in xfns.c."
>    (ns-read-file-name prompt dir mustmatch default_filename only_dir_p))
>  

I guess it would be good to change the function arguments names too to
avoid the underscores.

Re: master 088171e053 1/2: Fix ns-win.el (x-file-dialog) declaration

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

> I guess it would be good to change the function arguments names too to
> avoid the underscores.

Yup.

Re: master 088171e053 1/2: Fix ns-win.el (x-file-dialog) declaration

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Po Lu <luangruo@yahoo.com> writes:
>
>> I guess it would be good to change the function arguments names too to
>> avoid the underscores.
>
> Yup.

Could you please do that?

I will probably be preoccupied for the next several days.

Thanks.

Re: master 088171e053 1/2: Fix ns-win.el (x-file-dialog) declaration

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

> Could you please do that?

Sure; now done.

Re: master 088171e053 1/2: Fix ns-win.el (x-file-dialog) declaration

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Sure; now done.

Thanks.