From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master ee6e4bc525: Update device-specific grab during drag-and-drop Date: Sun, 21 Aug 2022 21:33:32 +0800 Message-ID: <87y1vhk9g3.fsf@yahoo.com> References: <165594564645.17861.9851899361770628544@vcs2.savannah.gnu.org> <20220623005406.BF9E6C01682@vcs2.savannah.gnu.org> <87czctn3zl.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24510"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Po Lu via Mailing list for Emacs changes To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 21 15:34:46 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oPl6E-00067W-1z for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Aug 2022 15:34:46 +0200 Original-Received: from localhost ([::1]:58794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oPl6D-0006Au-4P for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Aug 2022 09:34:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41134) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oPl5H-0005Qt-Dx for emacs-devel@gnu.org; Sun, 21 Aug 2022 09:33:47 -0400 Original-Received: from sonic316-20.consmr.mail.ne1.yahoo.com ([66.163.187.146]:34646) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oPl5F-0001So-Kz for emacs-devel@gnu.org; Sun, 21 Aug 2022 09:33:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1661088821; bh=eUQz1WZt7PM/g7tQzlUebQjHd4vfjhE1yBoeutpQ9v0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=ngAWPkrdVLRSaJyFEXm1DRqHh8lRSUVOEt6aKTRoJACPEmdVRjA6TukF6VmXcGg0I74pQlobGAuk+uRPXKEi2Hd+R60SPhooc7SdOX/LdEY5Ua2i+eZq7zSeOoO1a5X95uZNFqwuPnHB3i69xcMVQ7CP7NUoCjW9ebGt9fV58nNZAJItr2zAr6I90cLFsF6q/7J2wmL/zD6mzhWj/8uvjE8Lqg+yCzElnw8E2ARZgOxmHUEQXjTvlku3/wn64CSR+U+rR+aS8U3CVff9oToTZ6JTrJfSjPWmt5aIIgrInc2g4EdYdO5/8XTIrKaI0ewh8mZI7/RU6xtIytDvcB51OQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1661088821; bh=cUX5nC0RFD1j2xOhEKj/gShy4lQwIGJ6hPAHxLECxNe=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=HjPT4mAANLcpYuPOVyc+YpXsZN8M9Avsegh+f/juUw5+yKa55H64P7wAu2Ib1ekFN6Nyzfj7CK9pPsdLca3P48r3h5TIA4cqcG7FWWBKz6NTBvlfzV1WAqnfR2N1nyJ5V+QFn4M8RDgouk3WfS0uGtQbWPgrGmo4AN6JdQNU/4E4LJ0gSElLv2/yNoPD7Z5THev69WgCGWlN/NH+ovLwTwJd6KQinxX26qE5LkoIY9KG6nF/zMO7+qiI8PPXQHORK05lYxA/wh+QzXtURONMTGAjp3FvIj1FDTofQhOp+M4gXOVE7+e6Kh6gjFJ5vgBAFJPPg4JSZqh8TRacrSfNCw== X-YMail-OSG: uHvUOyEVM1mGxqeBc9gQ8GOqueIjvL.RmNm6Mf3R8UncHszjJHUKBoFW3FKCpv2 3R1aI25tQkM.mSdF4cG.8AIce9eIDteiIw_IiPC94wp87G1PYY8B0i8.rDK.NtenKnxxCw7oPN0c 8zZJpwe_x6p77Wm64JGzAu0DrWmNnFLoUILhFckGKzIU1Gp0tFpSz5uoHWz30lXzfmFyA5VR9mvu .AZE7.SX9xiA8l5AXKTsIj5HmUpUe8JCxlpzO.9au8W7EZSpfbHUT5P6hkmBJyPrF68ltfDiljAu PmaJAZtPoAZV87snr5lYU.EVAzj52nNAJZ0d_.tO37OMv9JY99L9W_ZWAfQUOtS0CJV7llkGuTIv H7_TN88F50.CmrtcfFX7_eg8gp7Y9bVud5W0UoyY64FfbH_SFL9Lv7eD7fFPiJFcTG4oxEm7gsJw XXRgicUCjObI9gSrqaffpHb0cct1g6q1OOm8UZUYae1EfyBGD_l.ax0ddLktQuHyqP.ZI6Fhn1q6 4mfoM8no0zvx5oW5d_zgUKaMh3iPk72rT9pqKFnUNbYmq.1.zmEHIm_K4d4s_U0h5rWuWuFF4m6q 02PZnVTfpXu7_nhUO6Q1zXqljkalCTD3HimBm.B_Douq5_o45gFAZNjdMmc80jZ_BzSHGOQ4jzM9 A1bJQGzSi_JNyfHu3xCt6BBQhpWU4peLaZwbZ68nlWz2Wu2DmBqLrnEEDE6SN09Acnu8q9NFr2f9 CbDGHT4aFt.NbbMwpnxn_ntd3s5MADQ0LdH6IX3pFpU7R0FTvhqINQKQbbDfRkKW91AvvBth0e9Q 5VSIZxL1QYDBQlWrS7GVyLyWJx_HBDSrTI3Aj_lsbp X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Sun, 21 Aug 2022 13:33:41 +0000 Original-Received: by hermes--canary-production-sg3-6f58cd9b5-jq7xs (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 4bfdd0b834d2644327ebd0d35e5900d0; Sun, 21 Aug 2022 13:33:37 +0000 (UTC) In-Reply-To: <87czctn3zl.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 21 Aug 2022 15:03:10 +0200") X-Mailer: WebService/1.1.20560 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.187.146; envelope-from=luangruo@yahoo.com; helo=sonic316-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293698 Archived-At: Lars Ingebrigtsen writes: > This (or something other change in this area) leads to the following > warnings in an --with-x-toolkit=no build on the current Ubuntu: > > xterm.c: In function 'handle_one_xevent': > xterm.c:21537:40: warning: potential null pointer dereference [-Wnull-dereference] > 21537 | device->grab &= ~(1 << xev->detail); > | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ > xterm.c:21537:40: warning: potential null pointer dereference [-Wnull-dereference] > 21537 | device->grab &= ~(1 << xev->detail); > | ^~ > > I haven't checked whether it's a correct warning or not. I guess it can happen if another bug makes Emacs "forget" devices, but I fixed all of those at the end of May. So for consistency I would enclose it with if (device), but I don't think the NULL dereference can actually happen in reality.