unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Philip Kaludercic <philipk@posteo.net>
To: Lucien Cartier-Tilet <lucien@phundrak.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Add new csetq macro
Date: Sun, 04 Sep 2022 17:07:01 +0000	[thread overview]
Message-ID: <87y1uzf4qy.fsf@posteo.net> (raw)
In-Reply-To: <87o7vvz7a7.fsf@phundrak.com> (Lucien Cartier-Tilet's message of "Sun, 04 Sep 2022 13:48:34 +0200")

Lucien Cartier-Tilet <lucien@phundrak.com> writes:

>> Note that this would have the issue that changes would automatically be
>> added to the "user" theme, and hence be reproduced in the
>> `custom-set-variables' section.  If the user sets an option using this
>> macro, and the `custom-set-variables' is evaluated after this point, the
>> intended change would be silently overridden.
>
> I must admit I completely forgot about the `custom-set-variables'
> section of the configuration since I disabled it entirely in my
> configuration, due to this behaviour precisely. But wouldn’t that be
> an issue if anything else like `setq' or `customize-variable' is used
> instead of `csetq'?

Yes, unless you make sure the customisation is not added to the user
theme, but either some other theme, as it is done with use-package or no
theme at all as is the case with setup.el.

> --
> Lucien “Phundrak” Cartier-Tilet
> <https://phundrak.com> (Français)
> <https://phundrak.com/en> (English)
> Sent from GNU/Emacs



      reply	other threads:[~2022-09-04 17:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-03 14:07 [PATCH] Add new csetq macro Lucien Cartier-Tilet
2022-09-03 15:11 ` Stefan Monnier
2022-09-04 11:40   ` Lucien Cartier-Tilet
2022-09-04 11:53     ` Lars Ingebrigtsen
2022-09-04 11:55       ` Lucien Cartier-Tilet
2022-09-05 16:35       ` [External] : " Drew Adams
2022-09-03 15:16 ` Stefan Kangas
2022-09-04 11:46   ` Lucien Cartier-Tilet
2022-09-03 15:59 ` Philip Kaludercic
2022-09-04 11:48   ` Lucien Cartier-Tilet
2022-09-04 17:07     ` Philip Kaludercic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1uzf4qy.fsf@posteo.net \
    --to=philipk@posteo.net \
    --cc=emacs-devel@gnu.org \
    --cc=lucien@phundrak.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).