From: Philip Kaludercic <philipk@posteo.net>
To: Adam Porter <adam@alphapapa.net>
Cc: emacs-devel <emacs-devel@gnu.org>,
Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: [ELPA] CSS improvements
Date: Sun, 11 Sep 2022 14:22:04 +0000 [thread overview]
Message-ID: <87y1uq2dpv.fsf@posteo.net> (raw)
In-Reply-To: <6028bb14-780f-c24c-3e3c-1e5b500e2c46@alphapapa.net> (Adam Porter's message of "Sun, 11 Sep 2022 08:38:12 -0500")
Adam Porter <adam@alphapapa.net> writes:
> Hi Stefan, Philip, et al,
>
> ELPA's CSS currently has a few small issues: some elements have no top
> margins, so they run into preceding elements; and some heading levels
> have the same appearance as normal body text.
>
> The attached patches resolve these problems and make, especially,
> package documentation much easier to read.
I wonder if this could also be addressed by rethinking the "reset"-rule
at the beginning of layout.css. I have tried removing it in Firefox,
and it doesn't look that bad (except for a few broken spacing rules that
shouldn't be that hard to solve).
> Thanks,
> Adam
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Hi Adam,
>
> Adam Porter [2022-09-11 08:38:12] wrote:
>> ELPA's CSS currently has a few small issues: some elements have no top
>> margins, so they run into preceding elements; and some heading levels have
>> the same appearance as normal body text.
>
> I have very little practice with CSS, so if you could point me to some
> concrete places (URL plus where in that page) which are improved, I'd
> really appreciate it.
> [ Clearly, that won't help me find out potential regressions, but it's
> better than nothing. ]
I've looked around and found at least two examples (that should
suffice for two patches):
- https://elpa.gnu.org/packages/vertico.html
Look for a code block that is followed by a paragraph. There is
almost no space above a paragraph, but enough above.
- https://elpa.gnu.org/packages/ement.html
Section 2.1 has a h4 title that is about the same size as the
paragraph that follows it. It appears at first as though the title is
part of the paragraph, especially because the paragraph has a lot of
space below it.
Btw, Adam it seems there is some peculiar rendering just below the
"2. Usage" title: On GitHub there appears to be a manual TOC, while
on the elpa.gnu.org it appears as a list with three empty elements.
> Other than that, your patches look good, thanks (no need to resend
> them).
>
>
> Stefan
next prev parent reply other threads:[~2022-09-11 14:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 13:38 [ELPA] CSS improvements Adam Porter
2022-09-11 14:06 ` Stefan Monnier
2022-09-11 14:22 ` Philip Kaludercic [this message]
2022-09-11 14:55 ` Stefan Monnier
2022-09-11 15:04 ` Philip Kaludercic
2022-09-11 20:09 ` Adam Porter
2022-09-11 21:27 ` Stefan Monnier
2022-09-12 8:30 ` Adam Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1uq2dpv.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=adam@alphapapa.net \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).