unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: emacs-devel@gnu.org
Cc: Vibhav Pant <vibhavp@gmail.com>
Subject: Re: feature/jit-improved-type-punning 9d2a54bd8d: src/comp.c: Use libgccjit's bitcast API for type coercion, when available.
Date: Wed, 28 Sep 2022 08:22:36 +0800	[thread overview]
Message-ID: <87y1u473g3.fsf@yahoo.com> (raw)
In-Reply-To: <20220927174358.8443FC00A6E@vcs2.savannah.gnu.org> (Vibhav Pant's message of "Tue, 27 Sep 2022 13:43:58 -0400 (EDT)")

Vibhav Pant <vibhavp@gmail.com> writes:

> branch: feature/jit-improved-type-punning
> commit 9d2a54bd8dac68b964649f7d04d04d9fa0096a62
> Author: Vibhav Pant <vibhavp@gmail.com>
> Commit: Vibhav Pant <vibhavp@gmail.com>
>
>     src/comp.c: Use libgccjit's bitcast API for type coercion, when available.
>     
> +#ifdef LIBGCCJIT_HAVE_gcc_jit_context_new_bitcast
> +  #define gcc_jit_context_new_bitcast fn_gcc_jit_context_new_bitcast
> +#endif

This is not how we write nested defines, IIRC.  They should be written
like so:

#ifdef LIBGCCJIT_HAVE_gcc_jit_context_new_bitcast
# define gcc_jit_context_new_bitcast fn_gcc_jit_context_new_bitcast
#endif

BTW, I don't see any code that loads this function dynamically on MS
Windows.  Isn't that needed?

> +#else /* !definedLIBGCCJIT_HAVE_gcc_jit_context_new_bitcast) */

Here, simply write:

  #else /* !LIBGCCJIT_HAVE_gcc_jit_context_new_bitcast */

or better, no comment, since what the else corresponds to is at a glance
obvious.



       reply	other threads:[~2022-09-28  0:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166430063807.1861.17209317756638644499@vcs2.savannah.gnu.org>
     [not found] ` <20220927174358.8443FC00A6E@vcs2.savannah.gnu.org>
2022-09-28  0:22   ` Po Lu [this message]
2022-09-28 11:10     ` feature/jit-improved-type-punning 9d2a54bd8d: src/comp.c: Use libgccjit's bitcast API for type coercion, when available Eli Zaretskii
2022-10-02 16:24       ` Vibhav Pant
2022-10-04 18:44       ` Andrea Corallo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1u473g3.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=emacs-devel@gnu.org \
    --cc=vibhavp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).