From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: master 59df0a7bd9: Add a VC command to prepare patches Date: Sat, 08 Oct 2022 17:29:09 +0000 Message-ID: <87y1tqp6l6.fsf@posteo.net> References: <166522273249.875.4607071661972312638@vcs2.savannah.gnu.org> <20221008095212.D8BB0C21CF8@vcs2.savannah.gnu.org> <87r0zib5d4.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40588"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Sean Whitton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 08 19:30:06 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohDeI-000ALT-Of for ged-emacs-devel@m.gmane-mx.org; Sat, 08 Oct 2022 19:30:06 +0200 Original-Received: from localhost ([::1]:44336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohDeG-0004Uq-LQ for ged-emacs-devel@m.gmane-mx.org; Sat, 08 Oct 2022 13:30:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53646) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohDda-0003aD-7g for emacs-devel@gnu.org; Sat, 08 Oct 2022 13:29:22 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:44555) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohDdU-0005dK-1a for emacs-devel@gnu.org; Sat, 08 Oct 2022 13:29:21 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id EE90D240103 for ; Sat, 8 Oct 2022 19:29:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1665250153; bh=eyloAGUrQb0LMdFG6Y1CSznNOouYq4VN8STko0NaRCM=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=jS2wL8qM652pEN7yXabpT34MhFX3z7fUElXHL3GIFeJVInEOsQHj246FGBGYDsDHX 6e6rd6WQBY0mRG5PWMgQLotMd50ouRuofGQFI35Er3qzxXC5ffFCv6MqYAyZJArh3r ailU6x/Lhqov9hbEM66SADS3KYlkmq0yHUDz7e2tifw8CtzBOrSV0596ueDLWScjst Vcy+vhVrLnmNOXyYKtE33p/Y/HvD28GkIFC0xhzB40BuHE2R9d1/Qnn83gG1yHqPZ+ CifK2x5Ta1H6kqF2GhHIUzTif+5OBOcmpLSSS7ayW2ycYhFbPapmZCOfL+WGaznXAd jYYH5oamQeZvA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MlBxN1ZyCz6tnr; Sat, 8 Oct 2022 19:29:09 +0200 (CEST) In-Reply-To: <87r0zib5d4.fsf@melete.silentflame.com> (Sean Whitton's message of "Sat, 08 Oct 2022 10:19:19 -0700") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297213 Archived-At: Sean Whitton writes: > Hello, > > On Sat 08 Oct 2022 at 05:52AM -04, Philip Kaludercic wrote: > >> +@vindex vc-prepare-patches-separately >> +Depending on the value of the user option >> +@code{vc-prepare-patches-separately}, @code{vc-prepare-patch} will >> +generate one or more messages. The default value @code{t} means >> +prepare and display a message for each revision, one after another. A >> +value of @code{nil} means to generate a single message with all >> +patches attached in the body. >> + >> +@vindex vc-default-patch-addressee >> +If you expect to contribute patches on a regular basis, you can set >> +the user option @code{vc-default-patch-addressee} to the address(es) >> +you wish to use. This will be used as the default value when invoking >> +@code{vc-prepare-patch}. Project maintainers may consider setting >> +this as a directory local variable (@pxref{Directory Variables}). >> + > > Please excuse me if I missed discussion in a bug, but wouldn't it make > sense to set *both* of these in .dir-locals.el for emacs.git? Yes, but I would wait a bit to avoid the same issues as we had when `diff-add-log-use-relative-names' was set. Anyone who had pulled the new commits with the change but hadn't rebuilt Emacs to know that these are safe values was prompted the "are you sure these variables are safe" queries. If we wait for a week or two then I would guess that most people following development will have pulled and rebuilt at least once by then.