From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: feature/package-vc has been merged Date: Sun, 06 Nov 2022 17:31:22 +0000 Message-ID: <87y1song5x.fsf@posteo.net> References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <87ilk1bgvd.fsf@posteo.net> <87edupbdp0.fsf@posteo.net> <875yg1bc02.fsf@posteo.net> <878rkxgpms.fsf@posteo.net> <87sfiyk3a2.fsf_-_@posteo.net> <838rkp4ptj.fsf@gnu.org> <87zgd58i7y.fsf@posteo.net> <83k0492u5i.fsf@gnu.org> <87fsew8g18.fsf@posteo.net> <83mt941cyd.fsf@gnu.org> <87fsewp0ec.fsf@posteo.net> <837d0814c9.fsf@gnu.org> <878rkooz1o.fsf@posteo.net> <831qqg1306.fsf@gnu.org> <874jvcowzm.fsf@posteo.net> <83y1soypvx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19547"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, rms@gnu.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 06 18:32:29 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1orjVU-0004td-Hq for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Nov 2022 18:32:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1orjUm-0007pU-Fg; Sun, 06 Nov 2022 12:31:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orjUk-0007p0-12 for emacs-devel@gnu.org; Sun, 06 Nov 2022 12:31:42 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orjUg-0007xT-2Z for emacs-devel@gnu.org; Sun, 06 Nov 2022 12:31:41 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 77236240107 for ; Sun, 6 Nov 2022 18:31:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667755891; bh=zvewB/9nrnGph6ojAWP2A3iX2+QzCnI2AS/Nb+1OTOc=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=Kc8mDUPK73A7Q6jU6f32y4cmgApC5tzcUB2YywrWLWRmjCnyL2bVmpWiZVeBJZyg1 nUxwy0X44h1ClucP6OAFqw54MQ+r3qtSdxMcDgE+l4ozuLiXv6W6xug4poIpOS9uW1 e6fA6Bv2zSS3lWT9ais8tPdvzRx7JXexSaYfod2wSf2Hk0/XjsPgVnHtXtKhBUOZLX 57w5w7ZbnwG2KYA5o4TPDpqkoVQK3WRQVpa0qWB37xkF9GIOm7VUUUGG9L2MBE80MH yTN/tuo/2Ue87/0nnrxeoptAz/0HNyKMy5GXvQenSCwEdejy95D5YWFF1upOwGNFpC r2xY5r5wchnNA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N51cf5qL2z9rxH; Sun, 6 Nov 2022 18:31:28 +0100 (CET) In-Reply-To: <83y1soypvx.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 06 Nov 2022 19:05:54 +0200") Autocrypt: addr=philipk@posteo.net; keydata= mQGNBGLfygUBDADVznbke6w0n9nE42xb+ZggbBy0IYRkkru/K+NA67523YTl2DoR2a5OMW90w7L9 KDtX2Mp34JN/6jVOSVC07VUbHVu6/exoGKixkiTpGhBPy5tUUJoxQKqLrzVQhN3fIyvg1oyHXKZm QGkUeevV0wjj4++xfjmcP235YvDh3TF8HC9t5KxIQIbhWnQm4ZyDkpWWS2CmdNttlj2+eH+51WLL bgx2bcwTmqrs079Q3hgF3yh44bBEmp9MgFjiZldOY2my0/ZSeucRxYmiM0vbJEBQgZV/MvA3gTxe 7ibV3ii7AyoYA8FiFDP98S/R2y5Nfq3ez9B7qeqtpSNseQHOU7h8Y5VV01a71ZszENAmbbwsldb9 j+HRLke7rn6mswDZl1qA/9ZFRzliFOdQtS1878XjraY+h5jfjvxaFVK23prGGVrrKv0LPWavoFUr nsjeHEZhYezBKhC2PwvRtXm01S3rkNbwm9pj0tfLSDW+1pT+6eZWptfQCXF2oEvgfKSTASUAEQEA AbQmUGhpbGlwIEthbHVkZXJjaWMgPHBoaWxpcGtAcG9zdGVvLm5ldD6JAdQEEwEKAD4WIQRxJuHe LwzjXHcL7QHyw8xRPbifZgUCYt/KBQIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAK CRDyw8xRPbifZkH+DACmCKmhrYgcv2i6dj3vRCVINaLtKUODTna/wAmP20WRKPhqvqvKNUx/wzpT aZrXIxpxOU2xawRWeHhWUktxS+W9L3xTACeR0gf5gomCxD9RuBTIohzWDkQt5rk8QwLqx5rAy5 Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299264 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: monnier@iro.umontreal.ca, rms@gnu.org, emacs-devel@gnu.org >> Date: Sun, 06 Nov 2022 16:42:37 +0000 >> >> Eli Zaretskii writes: >> >> >> That I did not know. The issue with copying is that you loose vc >> >> information. >> > >> > Why do they need VC information inside ~/.emacs.d/ ? >> >> While not strictly necessary, a big part of the motivation of package-vc >> is the ability to easily work on packages that are usable as regular >> packages. If I M-x find-function into a ~/.emacs.d/elpa/ and make a few >> changes, having to distinguish between packages between packages with >> :lisp-dir attributes and those without seems unnatural. > > Sorry, I don't follow: what does find-function etc. have to do with > having the VCS data inside ~/.emacs.d/elpa/? By "vc information" you > meant what Git stores in the .git directory, yes? I'm asking why it's > important to have that in ~/.emacs.d/elpa/. > > Or maybe I don't understand what you mean by "work on packages that > are usable as regular packages"? Let's say I notice a something I would want to change/add/fix in a package I am using. find-function is just one way I would query Emacs to open up the source, then make a few changes. If I decide that these are worth up-streaming, it is nice to just commit them right away and call `package-vc-prepare-patch' to send the maintainer an email. That last part won't work if the files were copied, because in that case I'll have to copy my changes back to the actual repository, create a commit in there, then send out the patch, which (right now) couldn't make immediate use of the package metadata, so you'd have to fall back to `vc-prepare-patch' and find out who the maintainer is manually. All of this would only apply to packages with external `:lisp-dir's, which doesn't immediately interest a user/developer. Having to keep this in mind would pointlessly expose an internal detail of package-vc that I'd like to avoid.