From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: feature/package-vc has been merged Date: Tue, 08 Nov 2022 20:15:25 +0000 Message-ID: <87y1slgq3m.fsf@posteo.net> References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <87zgd58i7y.fsf@posteo.net> <83k0492u5i.fsf@gnu.org> <87fsew8g18.fsf@posteo.net> <83mt941cyd.fsf@gnu.org> <87fsewp0ec.fsf@posteo.net> <837d0814c9.fsf@gnu.org> <878rkooz1o.fsf@posteo.net> <831qqg1306.fsf@gnu.org> <874jvcowzm.fsf@posteo.net> <83y1soypvx.fsf@gnu.org> <87y1song5x.fsf@posteo.net> <83v8nsyof7.fsf@gnu.org> <87leoond7l.fsf@posteo.net> <83r0yfzz01.fsf@gnu.org> <87bkpjyx3p.fsf@posteo.net> <83bkpjynmj.fsf@gnu.org> <87iljqya44.fsf@posteo.net> <8335auzo9s.fsf@gnu.org> <87zgd2ws8z.fsf@posteo.net> <831qqezkxj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31311"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, rms@gnu.org, emacs-devel@gnu.org, Lars Ingebrigtsen To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 08 21:16:10 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1osV10-0007uq-CV for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Nov 2022 21:16:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osV0V-0001pY-6R; Tue, 08 Nov 2022 15:15:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osV0S-0001pI-KD for emacs-devel@gnu.org; Tue, 08 Nov 2022 15:15:36 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osV0Q-0002iR-LK for emacs-devel@gnu.org; Tue, 08 Nov 2022 15:15:36 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id C791C24002A for ; Tue, 8 Nov 2022 21:15:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667938532; bh=8kg/Ebfod3pEnD9RXU9PohHrnuUAkTLMol1fmoeu43A=; h=From:To:Cc:Subject:Date:From; b=crognJoS9KCPMUhBCEirX22o4fSDvnw14IzJVsigtEVLWTbJ85jDgIJ4cQYe4SW0Y kGbvYLGcYnsq8Wt/UEVY9gCbCzlxcNIp113/Ac7+Tn1a4DkkgbmFqjc+xnqjPSvFzR Bf1lX6gFy02P3Vodn/S+ffbBlMLghyH6SPDHk+QZ8I0IvoPF8v+suh272nEnx/6O4V Br7hOOL8zvPFRsN0qk9vW7xVNNlIDiZJM2rZHhUs8L7Cl48wKahBziHrJ5+1tOVyqS d0H2o32B1LxTnl1QmIKogbe1pkZMKvehSjls5ONNOtk+IcoKjNVPkzvDPtlYo9+9Ig 2C94UtPCYuVsw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N6K8t4TBzz6tmd; Tue, 8 Nov 2022 21:15:26 +0100 (CET) In-Reply-To: <831qqezkxj.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 07 Nov 2022 20:19:52 +0200") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299364 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: monnier@iro.umontreal.ca, rms@gnu.org, emacs-devel@gnu.org >> Date: Mon, 07 Nov 2022 18:10:04 +0000 >> >> Eli Zaretskii writes: >> >> > OK, but my question was why all of this gets magically done when you >> > clone the repository outside ~/.emacs.d/elpa, but does not get done >> > when you clone it inside? I thought this is what you were alluding to >> > when I asked why not clone into ~/.emacs.d. >> >> Oh no, I'm sorry if I implied this somehow. This is neither the case in >> or outside of ~/.emacs.d/elpa. Somehow, someone has to do all of this. >> And one someone is package-vc. > > So my proposal is to clone the repositories below ~/.emacs.d/elpa/, > and thus solve the problem of linking/copying of files from the > repository to .emacs.d (and several others, which you and Stefan for > some reason don't consider important enough). > > And with that, let me bow out of this, since I think you understand > well enough what I proposed and can make your own decisions. I have implemented the necessary changes, and it appears to work. One reservation I have is the following change: --8<---------------cut here---------------start------------->8--- @@ -1090,17 +1096,19 @@ package-generate-autoloads (backup-inhibited t) (version-control 'never)) (loaddefs-generate - pkg-dir output-file - nil - "(add-to-list 'load-path (directory-file-name - (or (file-name-directory #$) (car load-path))))") + (file-name-concat pkg-dir lisp-dir) + output-file nil + (prin1-to-string + `(add-to-list 'load-path + (directory-file-name + ,(file-name-concat pkg-dir lisp-dir))))) (let ((buf (find-buffer-visiting output-file))) (when buf (kill-buffer buf))) auto-name)) --8<---------------cut here---------------end--------------->8--- Git tells me that Lars was wrote the "(or (file-name-directory #$) (car load-path))" bit, so I've added him to the CC's: Can you explain what the intention was here, and if my suggested replacement would break anything?