From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: Make peg.el a built-in library? Date: Sun, 27 Nov 2022 17:09:38 -0800 Message-ID: <87y1rvkhpp.fsf@ericabrahamsen.net> References: <875yvtbbn3.fsf@ericabrahamsen.net> <877d07a16u.fsf@localhost> <87tu3asg2r.fsf@ericabrahamsen.net> <87edud25ov.fsf@localhost> <87a6511ku0.fsf@ericabrahamsen.net> <87wn85z0zl.fsf@ericabrahamsen.net> <87leobplpv.fsf_-_@ericabrahamsen.net> <87bkp7ct7f.fsf@localhost> <875yfe7ols.fsf@ericabrahamsen.net> <87a64pbwkl.fsf@localhost> <878rjxkw4j.fsf@ericabrahamsen.net> <831qporcz4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9767"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: yantar92@posteo.net, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 28 02:10:32 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozSfH-0002Lb-E7 for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Nov 2022 02:10:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozSeZ-0008Ow-TJ; Sun, 27 Nov 2022 20:09:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozSeX-0008LS-Q5 for emacs-devel@gnu.org; Sun, 27 Nov 2022 20:09:45 -0500 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozSeV-0001V4-Qe; Sun, 27 Nov 2022 20:09:45 -0500 Original-Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id A22D6FA5A1; Mon, 28 Nov 2022 01:09:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1669597781; bh=mYIXbHijAKymRPrmxiX2zu4+tfBDiEUo9o/UpMwJ+nc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=uJxfqr/KSOvvwpbm347MiQpVLU6yzx8verME+IVjCLZ8DN83xpTRLBjwBE++RZLAb C6KEfV5lnVU+RcM2b8PXn3CF9bK+PGeaVOMpAI2bEoFZ/eYuoA28+9BPN5kZxRoqH+ T93tpgzlHZZv5AxOFEeLrTOzv7lLUf1S52W/Osm0= In-Reply-To: <831qporcz4.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 27 Nov 2022 10:57:51 +0200") Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300655 Archived-At: On 11/27/22 10:57 AM, Eli Zaretskii wrote: >> From: Eric Abrahamsen >> Cc: emacs-devel@gnu.org >> Date: Sat, 26 Nov 2022 17:46:04 -0800 >> >> Here's a new version, that I hope clarifies these questions (instead of >> doing the opposite). > > Thanks, a few minor comments below. Thank you! I feel like you've given me many of the same notes in the past (particularly @xref/@ref), I'll get it eventually. >> Lastly, nobody with a maintainer's hat on has actually given the green >> light on this, and I assume we'll want to hold off until the next >> version of Emacs is released; anyway it would be good to know what >> Eli/Lars think. I haven't done any NEWS additions or anything, either. > > What exactly are you asking about here? Making peg.el a built-in. I looked back over this whole thread and it turns out you already gave the OK early on, but now I'm not sure if this would go in Emacs proper, or as a built-in package... So that's my question. Where is the natural place to put it? >> @c -*-texinfo-*- >> @c This is part of the GNU Emacs Lisp Reference Manual. > > This would mean a suitable change to elisp.texi at the least, and probably > also to another file that is part of the ELisp reference manual sources? This would depend on how, exactly, it gets included. [...] >> @example >> (defvar number-grammar >> '((number sign digit (* digit)) >> (sign (or "+" "-" "")) >> (digit [0-9]))) > > Btw, this begs a question: how come the value of the variable is a (quoted) > list, but the value you pass to peg-parse in the previous example was not > quoted? peg-parse is a macro, peg-run is a function. peg-parse constructs a call to peg-run, passing in the car of whatever list you've given to it as the argument. The rest of your comments seem straightforward, I'll make those edits now. Thanks, Eric