unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [elpa] externals/org-modern 0043e584db: Use `display ""` for hiding instead of `invisible t`
       [not found] ` <20221130175752.70424C00B0F@vcs2.savannah.gnu.org>
@ 2022-11-30 19:55   ` Stefan Monnier
  2022-12-01  2:28     ` Visuwesh
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2022-11-30 19:55 UTC (permalink / raw)
  To: Daniel Mendler; +Cc: emacs-devel

>     Use `display ""` for hiding instead of `invisible t`

`invisible t` is usually a quick&dirty option but a better choice is to
use a non-nil non-t value.

>     Unfortunately it seems that the invisible text property has been taken by
>     org-fold-core.

What do you mean by that?

>     I am not entirely sure, but I think there are downsides of using
>     display "". Anyway let's try this for a while and see.

Indeed, `invisible` tends to interact a little better with various other
elements, such a cursor motion, isearch , ...


        Stefan




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [elpa] externals/org-modern 0043e584db: Use `display ""` for hiding instead of `invisible t`
  2022-11-30 19:55   ` [elpa] externals/org-modern 0043e584db: Use `display ""` for hiding instead of `invisible t` Stefan Monnier
@ 2022-12-01  2:28     ` Visuwesh
  2022-12-01  7:30       ` Kévin Le Gouguec
  0 siblings, 1 reply; 4+ messages in thread
From: Visuwesh @ 2022-12-01  2:28 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Daniel Mendler, emacs-devel

[புதன் நவம்பர் 30, 2022] Stefan Monnier wrote:

>>     Unfortunately it seems that the invisible text property has been taken by
>>     org-fold-core.
>
> What do you mean by that?

In the latest release of Org, the outlines no longer use overlays to
fold but text-properties.  All the assorted stuff was put in a general
purpose library called "org-fold".



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [elpa] externals/org-modern 0043e584db: Use `display ""` for hiding instead of `invisible t`
  2022-12-01  2:28     ` Visuwesh
@ 2022-12-01  7:30       ` Kévin Le Gouguec
  2022-12-05 11:35         ` Ihor Radchenko
  0 siblings, 1 reply; 4+ messages in thread
From: Kévin Le Gouguec @ 2022-12-01  7:30 UTC (permalink / raw)
  To: Visuwesh; +Cc: Stefan Monnier, Daniel Mendler, emacs-devel, Ihor Radchenko

Visuwesh <visuweshm@gmail.com> writes:

> [புதன் நவம்பர் 30, 2022] Stefan Monnier wrote:
>
>>>     Unfortunately it seems that the invisible text property has been taken by
>>>     org-fold-core.
>>
>> What do you mean by that?
>
> In the latest release of Org, the outlines no longer use overlays to
> fold but text-properties.  All the assorted stuff was put in a general
> purpose library called "org-fold".

Relevant bit from ORG-NEWS:

> *** Users experiencing performance issues can use new folding backend
> 
> The old folding backend used in Org is poorly scalable when the file
> size increases beyond few Mbs.  The symptoms usually include slow
> cursor motion, especially in long-running Emacs sessions.
> 
> A new optimized folding backend is now available, and enabled by
> default.  To disable it, put the following to the Emacs config *before*
> loading Org:
> 
> #+begin_src emacs-lisp
> (setq org-fold-core-style 'overlays)
> #+end_src
> 
> Even more performance optimization can be enabled by customizing
> =org-fold-core--optimise-for-huge-buffers=.  However, this option may
> be dangerous.  Please, read the variable docstring carefully to
> understand the possible consequences.
> 
> When =org-fold-core-style= is set to =text-properties=, several new
> features will become available and several notable changes will happen
> to the Org behavior.  The new features and changes are listed below.
>
> [ subsections elided for brevity ]
> **** Hidden parts of the links can now be searched and revealed during isearch
> **** =org-catch-invisible-edits= now works for hidden parts of the links and for emphasis markers
> **** Breaking structure of folded elements automatically reveals the folded text
> **** Folding state of the drawers is now preserved when cycling headline visibility
> **** =outline-*= functions may no longer work correctly in Org mode

My understanding (based only on skimming mailing lists, haven't tried
Org 9.6 yet):

* org-fold-core-style is 'text-properties by default,

* ISTR a bug-gnu-emacs thread where overlay performance was improved, so
  I wondered if Org 9.6 might revert to overlays by default and make the
  new backend opt-in,

* then again ORG-NEWS advertises "new features" with the new backend, so
  it's not just a matter of performance I guess?

Paging Ihor in, to dispel any misunderstanding of mine.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [elpa] externals/org-modern 0043e584db: Use `display ""` for hiding instead of `invisible t`
  2022-12-01  7:30       ` Kévin Le Gouguec
@ 2022-12-05 11:35         ` Ihor Radchenko
  0 siblings, 0 replies; 4+ messages in thread
From: Ihor Radchenko @ 2022-12-05 11:35 UTC (permalink / raw)
  To: Kévin Le Gouguec
  Cc: Visuwesh, Stefan Monnier, Daniel Mendler, emacs-devel

Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:

> * org-fold-core-style is 'text-properties by default,

Yes

> * ISTR a bug-gnu-emacs thread where overlay performance was improved, so
>   I wondered if Org 9.6 might revert to overlays by default and make the
>   new backend opt-in,

We might, after we drop support for Emacs <29 and also implement "new
features" for overlays.

> * then again ORG-NEWS advertises "new features" with the new backend, so
>   it's not just a matter of performance I guess?

Yup. I added, for example, auto-unfolding broken syntax elements (when
you, say, edit folded :drawer:... to become drawer:, its contents is
unfolded).

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-12-05 11:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <166983107217.27025.10929395413721986131@vcs2.savannah.gnu.org>
     [not found] ` <20221130175752.70424C00B0F@vcs2.savannah.gnu.org>
2022-11-30 19:55   ` [elpa] externals/org-modern 0043e584db: Use `display ""` for hiding instead of `invisible t` Stefan Monnier
2022-12-01  2:28     ` Visuwesh
2022-12-01  7:30       ` Kévin Le Gouguec
2022-12-05 11:35         ` Ihor Radchenko

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).