From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Felix Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] change dired--find-possibly-alternative-file behaviour. Date: Sun, 26 Feb 2023 07:07:10 +0100 Message-ID: <87y1olgdca.fsf@web.de> References: <87mt51o5bu.fsf@web.de> <83ttz9j8up.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32425"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.9.3; emacs 30.0.50 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 26 07:22:02 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pWAQ6-0008Hc-Fl for ged-emacs-devel@m.gmane-mx.org; Sun, 26 Feb 2023 07:22:02 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWAPH-0001y8-C0; Sun, 26 Feb 2023 01:21:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWAPF-0001xl-L0 for emacs-devel@gnu.org; Sun, 26 Feb 2023 01:21:09 -0500 Original-Received: from mout.web.de ([212.227.15.3]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWAPB-0002bT-5L; Sun, 26 Feb 2023 01:21:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1677392462; i=felix.dick@web.de; bh=C9kMfZxlajncnvECd5N4RY+roSuzTAAjLlWpgZOGaoQ=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:Date:In-reply-to; b=bn3/xlFyKsm6V9J5mNE2cygIdJGpcixJcrxXTkHG7aXSprL0DtiVDw804LhPfhIys 5OhCF+vKrZFgxMy74iTh1DMJ7W3SnsQ2zT9NS4GIHr0dHPYkGze5tc5VQb43UDPM+Z z6RC9SywYbz+VOsXDVjd2C9KJqRFL9oD2evNjrcZ9zk7Ih3EoT6OsTYsfHUwzLwukF ztbUa97VsSYbyGCaeVUUWkGZiWA1TA4I/OQEB6LYr+4kXSyc18y+AthKLIwMNQqVOj B3Tn1QftQvDSIRUFopp4GdToQwD2pL/FbuZygbyMZEiyGpgxH03AOcZL4OePlTQ5u5 U1DdQfjsdRj8Q== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from felix-lifebooka531.web.de ([95.91.210.207]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1Mx0Ix-1oYGMH2kkF-00y8s3; Sun, 26 Feb 2023 07:21:02 +0100 In-reply-to: <83ttz9j8up.fsf@gnu.org> X-Provags-ID: V03:K1:LAFrf43GLYKdjxdJX9KYaC5mPqh59/IEdP0vvyHPeG2dpkDeOTX bql+v7txzUE7w5Q6PIJtihxlde9G26FA4LKiv8I9RxAWdLA34TMNH8327P+LYlaFtfzbmVA 0+Dh+wi11e7I2msv2fc62KWtqqVKJcvGLmni9oFbLkHcJI0c66XEzuPrnTPncZpNahbG/CF e+G6mP0JxBl13IOThgg6Q== UI-OutboundReport: notjunk:1;M01:P0:sJVciiia3mQ=;MRylzuBI8Ejg1Zu/kD7IjHDq/Jr HdI1lK090c/Nb+VCe5SsqUFbqHwsz3LZlGAYRHNesU6qHbfd5zN5DDIfQZRuc2tLWhKmeALwn uulD/+j8zQMfyoyf6FPfzk9oB8URfWdvHzD+Jm8qUeNnuKl3jxEJf4XTG6y7MIVRj4vew4pnn VbyAflQBuvPV2c8O7+F/AvXqBKMB5g36LEgMkTC9WXu6iPDA60ULu/MPLpLOkRzEhc6bj2Cwc 7JJOZZEDCfZg8mCa9IQh8iYjrSo80pd+saNsifexXPjN3We1EhMTcq1pUOJjFFgeG7lIXPg7o g+oEVcBP/kNoiT0PQiopn/UXYQ15er1TkfAhoWjlopt4pn+4lc0gjddaNepcGeSU2r/oH/FTU /FqjjYN7lEpzHFXAYJP81/yWvS9pA5dnQUIrAwKJpENfsj1U8pFuA9eOfvweIWcghrebvEznc NmkOaxIFIU15ZV+QiOUfnONHxTdHekkqnzkHNOcS8kVT0PX7NPEZo/VB8U7qwE6n5LMt395WL gU71A9lk4tz9pU0uAe8juublw4ukjp5gqdppgqyIufrtoflinldaJGpDdoLhk04qWzDf+uxlg 6IbExnfakAjEfOTXmeLDTHg6Fpsa5xcDjs4Mk1bRfsTJwBBEAh3xZLNxhaGRslNEZtaphfMKg cp96GnS29dr4nU5pnKtS+c0LeGLByS9LVzEiwzzEOiG0wQR3qz0Z8fDdOv5K+g1ZTtYw80+xs IjZNXIJrAH6Xm/KnPLqpLPL19qYxORwqxM5nMTrdccVmxVKkzC7NYg72ATT+8/DPIKTusiMq Received-SPF: pass client-ip=212.227.15.3; envelope-from=felix.dick@web.de; helo=mout.web.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303811 Archived-At: Eli Zaretskii writes: >> From: Felix >> Date: Sat, 25 Feb 2023 20:43:57 +0100 >> >> diff --git a/lisp/dired.el b/lisp/dired.el >> index 76499d0f520..620508bef4f 100644 >> --- a/lisp/dired.el >> +++ b/lisp/dired.el >> @@ -2728,7 +2728,8 @@ dired-find-file >> (defun dired--find-possibly-alternative-file (file) >> "Find FILE, but respect `dired-kill-when-opening-new-dired-buffer'." >> (if (and dired-kill-when-opening-new-dired-buffer >> - (file-directory-p file)) >> + (file-directory-p file) >> + (= (length (get-buffer-window-list)) 1)) >> (progn >> (set-buffer-modified-p nil) >> (dired--find-file #'find-alternate-file file)) > > What if get-buffer-window-list returns nil? The optional argument BUFFER-OR-NAME of get-buffer-window-list defaults to the current buffer, shouldn't that garantee that it never returns nil?