Re: [elpa] main b8d4806d47: * elpa-packages (switchy-window): Ignore LICENSE and Makefile

Re: [elpa] main b8d4806d47: * elpa-packages (switchy-window): Ignore LICENSE and Makefile

[Philip Kaludercic]

Tassilo Horn <tsdh@gnu.org> writes:

> branch: main
> commit b8d4806d471f8f323254ef58efe39d021d8443d2
> Author: Tassilo Horn <tsdh@gnu.org>
> Commit: Tassilo Horn <tsdh@gnu.org>
>
>     * elpa-packages (switchy-window): Ignore LICENSE and Makefile
> ---
>  elpa-packages | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/elpa-packages b/elpa-packages
> index a12f009930..86c91734b8 100644
> --- a/elpa-packages
> +++ b/elpa-packages
> @@ -631,7 +631,8 @@
>    :manual-sync t
>    )
>   (switchy-window	:url "https://git.sr.ht/~tsdh/switchy-window"
> -  :readme "README.md")
> +  :readme "README.md"
> +  :ignored-files ("LICENSE" "Makefile"))

Shouldn't the .elpaignore handle this?

>   (sxhkdrc-mode		:url "https://git.sr.ht/~protesilaos/sxhkdrc-mode"
>    :readme "README.md"
>    :ignored-files ("COPYING"))
>
>

-- 
Philip Kaludercic

Re: [elpa] main b8d4806d47: * elpa-packages (switchy-window): Ignore LICENSE and Makefile

[Tassilo Horn]

Philip Kaludercic <philipk@posteo.net> writes:

>> @@ -631,7 +631,8 @@
>>    :manual-sync t
>>    )
>>   (switchy-window	:url "https://git.sr.ht/~tsdh/switchy-window"
>> -  :readme "README.md")
>> +  :readme "README.md"
>> +  :ignored-files ("LICENSE" "Makefile"))
>
> Shouldn't the .elpaignore handle this?

Hm, I think you are right and I fell prey to cargo-culting from other
packages.  Reverted.

Bye,
Tassilo

Re: [elpa] main b8d4806d47: * elpa-packages (switchy-window): Ignore LICENSE and Makefile

[Tassilo Horn]

Hi Philip,

I think I need some ELPA help.  The package still hasn't appeared.

Yesterday evening, I got a mail with a build error caused by the
Copyright notice still mentioning myself and not the FSF.  I have fixed
that but still the package isn't online (and my experience with, e.g.,
AUCTeX suggests ELPA builds quite frequently nowadays).  Even more, I
cannot build the package locally and don't understand the error:

--8<---------------cut here---------------start------------->8---
elpa on  main 
❯ make packages/switchy-window
Byte compiling packages/switchy-window/switchy-window.el
Unable to activate package ‘switchy-window’.
Required package ‘compat-29.1.3.4’ is unavailable

In toplevel form:
packages/switchy-window/switchy-window.el:59:2: Error: Cannot open load file: No such file or directory, compat
make: *** [GNUmakefile:119: packages/switchy-window/switchy-window.elc] Error 1

elpa on  main 
❯ realpath packages/switchy-window
/home/horn/Repos/el/elpa/packages/switchy-window

elpa on  main 
❯ make build/switchy-window
emacs --batch -l /home/horn/Repos/el/elpa/admin/elpa-admin.el	\
         -f elpaa-batch-make-one-package switchy-window
======== Building tarball archive/switchy-window-1.0.tar...
Build error for archive/switchy-window-1.0.tar: (error "Can’t find main file /home/horn/Repos/el/elpa/packages/switchy-window/switchy-window.el file in /home/horn/Repos/el/elpa/packages/switchy-window/")
######## Build of package archive/switchy-window-1.0.tar FAILED!!

elpa on  main 
❯ ls -l /home/horn/Repos/el/elpa/packages/switchy-window/
total 56
-rw-r--r-- 1 horn horn 35141  9. Apr 23:21 LICENSE
-rw-r--r-- 1 horn horn   335 10. Apr 09:33 Makefile
-rw-r--r-- 1 horn horn  2863 10. Apr 09:33 README.md
-rw-r--r-- 1 horn horn  8355 10. Apr 09:33 switchy-window.el
--8<---------------cut here---------------end--------------->8---

Why can't it require compat?  I've bumped the compat version to 29.1.4.1
now (which is the most current version which I have installed locally,
too) and tried again after "make sync/switchy-window".  Now I get:

--8<---------------cut here---------------start------------->8---
elpa on  main 
❯ make package/switchy-window
make: *** No rule to make target 'package/switchy-window'.  Stop.

elpa on  main 
❯ make build/switchy-window
emacs --batch -l /home/horn/Repos/el/elpa/admin/elpa-admin.el	\
         -f elpaa-batch-make-one-package switchy-window
======== Building tarball archive/switchy-window-1.0.tar...
Build error for archive/switchy-window-1.0.tar: (error "Can’t find main file /home/horn/Repos/el/elpa/packages/switchy-window/switchy-window.el file in /home/horn/Repos/el/elpa/packages/switchy-window/")
######## Build of package archive/switchy-window-1.0.tar FAILED!!
--8<---------------cut here---------------end--------------->8---

Why can't it find
/home/horn/Repos/el/elpa/packages/switchy-window/switchy-window.el which
actually does exist?

And the local build aside, to I need to increment the Version in order
to trigger another try by ELPA after a failure?

Bye,
Tassilo

Re: [elpa] main b8d4806d47: * elpa-packages (switchy-window): Ignore LICENSE and Makefile

[Philip Kaludercic]

Tassilo Horn <tsdh@gnu.org> writes:

> Hi Philip,
>
> I think I need some ELPA help.  The package still hasn't appeared.
>
> Yesterday evening, I got a mail with a build error caused by the
> Copyright notice still mentioning myself and not the FSF.  I have fixed
> that but still the package isn't online (and my experience with, e.g.,
> AUCTeX suggests ELPA builds quite frequently nowadays).  Even more, I
> cannot build the package locally and don't understand the error:

[...]

> Why can't it find
> /home/horn/Repos/el/elpa/packages/switchy-window/switchy-window.el which
> actually does exist?
>
> And the local build aside, to I need to increment the Version in order
> to trigger another try by ELPA after a failure?

I suspect that this is the issue.  IIRC elpa-admin picks the latest
commit that incremented the Version tag for packaging, then checks if
the copyright is OK.  That is probably also the reason why on my end the
devel build works (which uses the latest commit), but the release
doesn't.

> Bye,
> Tassilo
>

-- 
Philip Kaludercic

Re: [elpa] main b8d4806d47: * elpa-packages (switchy-window): Ignore LICENSE and Makefile

[Tassilo Horn]

Philip Kaludercic <philipk@posteo.net> writes:

Hi Philip,

>> Why can't it find
>> /home/horn/Repos/el/elpa/packages/switchy-window/switchy-window.el which
>> actually does exist?
>>
>> And the local build aside, to I need to increment the Version in
>> order to trigger another try by ELPA after a failure?
>
> I suspect that this is the issue.  IIRC elpa-admin picks the latest
> commit that incremented the Version tag for packaging, then checks if
> the copyright is OK.  That is probably also the reason why on my end
> the devel build works (which uses the latest commit), but the release
> doesn't.

Thanks, indeed that seems to be the issue.  After bumping the version,
it builds locally so I guess it'll appear shortly.

Bye,
Tassilo