From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: Is it valid to call isearch-filter-predicate outside isearch? Date: Fri, 02 Jun 2023 09:07:04 +0000 Message-ID: <87y1l244hz.fsf@localhost> References: <875y8nks9t.fsf@localhost> <87fs7c10cq.fsf@web.de> <87v8g79zoe.fsf@localhost> <87sfbasr8m.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36657"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 02 11:03:39 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q50h8-0009Fo-48 for ged-emacs-devel@m.gmane-mx.org; Fri, 02 Jun 2023 11:03:38 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q50gF-00054Z-D8; Fri, 02 Jun 2023 05:02:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q50gD-00054A-H8 for emacs-devel@gnu.org; Fri, 02 Jun 2023 05:02:41 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q50g9-0007Yp-DT for emacs-devel@gnu.org; Fri, 02 Jun 2023 05:02:41 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id B6D36240101 for ; Fri, 2 Jun 2023 11:02:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1685696552; bh=4bKfoKQSI5tEhCh54j/P8PrRkhbxcl3JyysrXF86W/4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=hx1Gd7SBcgi42gYGNB6HvBMjP00dfu3zvrJ4NYzpHSPI8mknawUIPotZpUobMIexB UunY6wniXsgWK/szGGn1w7RZz7cGaoB+SD3p6ZYP26cvYLdF7N/R7zZ0oWgkTS4fCy J8ofLsjjJYwWt8gqWJJEvOhUZ5s04ND+ObxxhDxp/3Alb1++Eqza5GSaeD53g0z9Rk MCizb9c/BAw+OrexN7UEA6dQuEUkYAvFVCThc4LZODSlSvDObLxMWYeCzv0APzvlyX qu5Y8pl101nldqbNUJJmBC8vUH1fwPBFnDJnsY6aFOAbZPRajIbY0/J0dgpXjMy4EH N0Vk5pyZE8EaA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QXcTN2FmYz9rxB; Fri, 2 Jun 2023 11:02:32 +0200 (CEST) In-Reply-To: <87sfbasr8m.fsf@web.de> Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306550 Archived-At: Michael Heerdegen writes: >> Surely not. `post-command-hook' is triggered after each >> `self-insert-command' during isearch/query-replace. > > Of course the idea is not to so something blindly. One could check > whether isearch is still active and which overlays need to be kept. This may work for isearch, but not in query-replace, evil, swiper and other places where isearch machinery is used. Or I will have to keep things up-to-date against every new user of isearch machinery. Not good idea, IMHO. >> I had to advice `isearch-clean-overlays', which appears to be called by >> all the users of `isearch-filter-predicate' (replace-regexp, evil-mode, >> and swipet). Still a workaround. Ugly. > > Hmm. Maybe the optimum. > > BTW, did you consider to :before advice the local variable > `isearch-filter-predicate' instead of overwriting it? That would be a > bit nicer for users and other modes that also need to change it. Do you refer to (add-function :before (local 'isearch-filter-predicate) #'foo) ? Two reasons: 1. I only vaguely understand how this works 2. It feels against the interface. If advising this predicate is expected, why not convert it into an abnormal hook? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at