From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Leak in selinux stuff? Date: Sat, 19 Aug 2023 11:37:06 +0800 Message-ID: <87y1i7em8t.fsf@yahoo.com> References: <87y1i7em8t.fsf.ref@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35806"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 19 05:38:04 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXCmq-00097v-NQ for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Aug 2023 05:38:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXCm8-0004QU-G2; Fri, 18 Aug 2023 23:37:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXCm6-0004QF-R7 for emacs-devel@gnu.org; Fri, 18 Aug 2023 23:37:18 -0400 Original-Received: from sonic308-10.consmr.mail.ne1.yahoo.com ([66.163.187.33]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXCm4-0005HV-Ej for emacs-devel@gnu.org; Fri, 18 Aug 2023 23:37:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1692416233; bh=cBPE8GVg/AqO5r7r0daeeFd6cNL8tABXcaDGNyzmaYM=; h=From:To:Subject:Date:References:From:Subject:Reply-To; b=IAVBIOie3K4iK1ylAyhkHVesLz9pbo4sVSVqGSv5QdEiIBomS2ZupjkW9cAAZ2JJQrxxmJaKdg1+SjS09GabA+JrcJ8oEDANGCfuIFWs0sf9gfsSiqsENzbX2tJxxt1iwKxLUNxSlY3SF7N8Gajfw3t4mNeA3sQJbFuRAM/Bj+6+X4O9cwH8K/l9Yc4cEPwAPs7qCbhcXq6xDtJaaCrbz1tGAWut506S1hAMuZHQIpnQ5bNR3Ne80SO312Ss7njn0I2koU+42TcuX9IcBWO0UdVbwZ+xNrc4/jSOyYOOKhzPOVU1MsnswbmHUw4WpBDa0FhmbtyoiOZS0CNXT5d+oQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1692416233; bh=OToibEKM3XsFZW/8PqZ/tWk7aR2GJ4m0wHIDbygT7x5=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=fRjD8UD9vMo6Q29qK/aPChFDrHzgwt2+fUOJZ8LAMKm5jK6OQQO0yrnfTc1lTps8z7/hF4OVaGZqhYahBuFUpd3axu1BPeJvI4Ce1p/v/7KFWEfW1SMPgFqDxyGKdmpct6HfbG7bg6p4BSQy1SM+Um5qEKXeDTq00dAENEIufDMglj1hRLrAvghJPy76G2SCpQiFGhDM+gilTx1XurUJB+U07mQjDKt6EsNPV1+sof6pAhFeN1EIVofM23AVKxvZPyhA76trrEgv5f5ulPzeYx9IaX1ei7g7KUzc3JlcaRqXKAs+K1oDXdYYfGhrBEXN7HISzj14bYiEzmt1UEaFwg== X-YMail-OSG: EqHUzI8VM1lP6CFZrBVWosbaviXzOTlmCdHp.Ih0IYINRgQ4cwcYwTrT5HunVsZ D.jMjU0Ceqy5bfw8ot5J2jWm3O_knLg2eQ6FEU4msuFJ6FaF9.nmA7i79PkODsz3AeyDMWsvHE8V 4fXuKOcYTlCUMaiElim_CYAD5_K.7pOJ503EAnwjIoTKtqc.822ci62DTpeS0GiDTpMsbOUtqxEy YBwW1WoqLmkc6ykzHyNPgHCK5P1S8ptxEmAVjJuxJ2RhmBcSnzSC6a.ytFxg5kL7OuMD5Nn.Aewy kCEzEykl3XLBL7LnJxPXsWmgfgY6r6IJkgTlPJV..49NAYEBexOz5GNYeUBtniDIpcyEHM7UZSAS Pgn283s9qs_bZcdAEzkbOuY2IbqkO8N5IX1CWW8wCP.FnaEQ31ieF23oK_UvJCq5ZOS1a1MdMFB2 e4MdFDoy3fz2kdyZ9Gosd7TqNYscCHrsssSDpOEh0eO9GBS5ju4YlkgLY.X31gYLL1.5zHIR2UZf zHh2iO8SFhDfw8yjdPX3MK_PW.ThbgRwoAs9BV_pgQDb4uVVEKNOIIIiGC9EDyvBrUJs7DxtT07q 2NgdDL_jpaQtIx71xx5drL3FYemw_8la69ilv.Ddv.b3SXL0xuAC.oE.4P3WGi1X3sItYvNvWLoY 3ajIDcC4hGW.9Li2uyxd4kvKtgF93brwZoediUqJpvS0PKhjM359lgxzHlVlbCh3Lb7zb47JxBT5 8nHe6E7M0isbcPqOjeEsAmqh..c3N.YtIkItxQEP1xj6il.jPIVOszvcIQtx6iKeGH_KV8j1oRUQ THWm_bLIRCS6cl1uqpg1epWbOc4Ei3E3DF.0L8nR4l X-Sonic-MF: X-Sonic-ID: a61a72b9-ff96-4438-90d9-0f6a64f410af Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ne1.yahoo.com with HTTP; Sat, 19 Aug 2023 03:37:13 +0000 Original-Received: by hermes--production-sg3-69654d8bd-l9pxw (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 3f9d5294c12cbd7495938e4c587fb6a6; Sat, 19 Aug 2023 03:37:10 +0000 (UTC) X-Mailer: WebService/1.1.21732 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.187.33; envelope-from=luangruo@yahoo.com; helo=sonic308-10.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308907 Archived-At: fileio.c is littered with code like such: /* See https://debbugs.gnu.org/11245 for ENOTSUP. */ if (fail && errno != ENOTSUP) report_file_error ("Doing lsetfilecon", absname); context_free (parsed_con); freecon (con); where `parsed_con' and `con' are allocated by libselinux functions by the likes of `lgetfilecon'. Around such code, no measures are apparently taken for deallocating those objects should a non local exit occur. Am I missing anything, or should this be fixed?