From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.devel Subject: Re: Adding with-editor to Emacs? Date: Sat, 02 Sep 2023 23:04:23 +0200 Message-ID: <87y1ho9tig.fsf@bernoul.li> References: <85msy98sni.fsf@elpa.gnu.org> <87r0nidkmt.fsf@bernoul.li> <83bkelc1p1.fsf@gnu.org> <87fs3xwzxm.fsf@bernoul.li> <837cp9bur7.fsf@gnu.org> <87a5u5wskw.fsf@bernoul.li> <8334zxayhx.fsf@gnu.org> <871qfgbg13.fsf@bernoul.li> <83v8cs8kts.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29339"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefankangas@gmail.com, emacs-devel@gnu.org, rms@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 03 06:34:21 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qceoX-0007Tt-6U for ged-emacs-devel@m.gmane-mx.org; Sun, 03 Sep 2023 06:34:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcena-0004n2-MO; Sun, 03 Sep 2023 00:33:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcXnF-0006LZ-P5 for emacs-devel@gnu.org; Sat, 02 Sep 2023 17:04:33 -0400 Original-Received: from mail.hostpark.net ([212.243.197.30]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcXnC-0005k1-GU; Sat, 02 Sep 2023 17:04:33 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id EB7CF164DD; Sat, 2 Sep 2023 23:04:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from; s=sel2011a; t=1693688665; bh=03jgizzA/Y5l2sugLv1b36oRfv/jdVKmLcGF4s1PLkM=; b= pfk2DatiM0S/DlzWEUkyrlZQX08DXgscMbehGyKsbm34VIWLFJEJOTYY4AcBkgyx RFNAyAfFeMduxlhvhjyl5XomvzEUgtRq2AuDdZ+6Gg0C4cHMB2F9QmcBtbnu1Eam Dn65LfYiGCnA1ss3MxaETVXweYE+APx7oBIGmeXxijg= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id UCOwlz2ZOwsW; Sat, 2 Sep 2023 23:04:25 +0200 (CEST) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 866C1164B2; Sat, 2 Sep 2023 23:04:25 +0200 (CEST) In-Reply-To: <83v8cs8kts.fsf@gnu.org> Received-SPF: pass client-ip=212.243.197.30; envelope-from=jonas@bernoul.li; helo=mail.hostpark.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 03 Sep 2023 00:33:12 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:309923 Archived-At: Eli Zaretskii writes: >> From: Jonas Bernoulli >> Cc: stefankangas@gmail.com, emacs-devel@gnu.org, rms@gnu.org >> Date: Sat, 02 Sep 2023 20:12:40 +0200 >> >> > Then I guess you should describe all those atrocities in detail, so >> > that we could perhaps devise ways of handling it. >> >> I do not have a list of those atrocities and I do not have the bandwidth >> and motivation to compile that in the next few months. I have code that >> deals with it though (with-editor-locate-emacsclient and the functions >> it uses). Using git to trace the history of that code, would give you >> commits with explanations and/or links to places were the issues that >> are being addressed were described. > > It's not that easy: AFAIU, with-editor was part of Magit, and was > separated into a repository of its own not very long ago. And the > answers to my questions seem to be before the split. That doesn't really complicate the archaeology, we would just have to run "git log ..." twice instead of just once. But yes, the history is more ancient as the first casual "git log ..." in the with-editor repository suggests. > I also looked at the present code and found it to have quite a few > non-trivial parts whose purpose I couldn't easily explain or guess, > and which are not explained in the comments, either. Yes and IMO it would even be fair to say the code is a bit weird, and we likely could do a better job by first listing all the cases we have to address and then start over. Doing that would also risk breaking something that was previously fixed. > So, if you have no time or motivation to describe the problems you > tried to solve with that code, I guess someone else will need to find > out and describe the problems in a way that we could then consider for > inclusion. I cannot myself afford digging through the Magit's Git > repository to find the description of these problems, sorry. I don't expect you to do that. And you don't expect me to do it either. If someone else decides to do it, that would be great, but if not, that's what it is. That would change once a (future) package that is part of Emacs, needs to something like with-editor's emacsclient kludge or the additional features it provides. Until then, I think we can shelve this. Hell, I might even one day decide to produce the list myself after all. But for the last few months "just one more thing" has just kept popping up, and I really want to finally get around to work on the things that I actually want to work on again. It has been a while. The server-window-alist thing is a different story, and as you said, should be handled separately. But that too is "just one more thing" in a long sequence of "just one more"... (Hm, in February I got a bit burnouty and took a break, which did wonders. It seem I am again approaching a point where that is the logical course of action. Sorry, if some of my "don't assign me any more work, I did not volunteer" was a bit rude.) > Or maybe Richard already knows the answers, since he thought this > should be added to Emacs.