Re: master ac797f60160 2/2: ; * lisp/net/shr.el (shr-image-zoom-levels): Fix wrong type.

[Robert Pluim <rpluim@gmail.com>]

>>>>> On Wed, 10 Jul 2024 10:46:57 +0000, Philip Kaludercic <philipk@posteo.net> said:

    Philip> Isn't that solved by adding a :greedy (see (widget) checklist).
    Philip> Arguably this should be enabled by default for `set' types.

That doesnʼt help. Hereʼs what the current type gets you:

    Hide Shr Image Zoom Levels:
    Set:
    [X] Fit to window size
    [X] Original size
    [ ] Full image size
    [X] Fill window height

All you can do is enable or disable each of the four entries. With my
suggestion, you get:

    Hide Shr Image Zoom Levels:
    Repeat:
    [INS] [DEL] Choice:
                (*) Fit to window size
                ( ) Original size
                ( ) Full image size
                ( ) Fill window height
    [INS] [DEL] Choice:
                ( ) Fit to window size
                (*) Original size
                ( ) Full image size
                ( ) Fill window height
    [INS] [DEL] Choice:
                ( ) Fit to window size
                ( ) Original size
                ( ) Full image size
                (*) Fill window height
    [INS]

So you can change the type of each entry, and add/delete entries.

If you do "(repeat (choice" you get this:

    Hide Shr Image Zoom Levels:
    Repeat:
    [INS] [DEL] Choice: [Value Menu] Fit to window size
    [INS] [DEL] Choice: [Value Menu] Original size
    [INS] [DEL] Choice: [Value Menu] Fill window height
    [INS]

which offers the same possibilities, but I prefer the 'radio' version.

Robert
--