From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Helmut Eller Newsgroups: gmane.emacs.devel Subject: Re: MPS: commit limit Date: Tue, 16 Jul 2024 18:27:07 +0200 Message-ID: <87y161ti90.fsf@gmail.com> References: <7PXYgVu5A8knQy6Q03cbm6FjO7s022nC0cqCRtUDhQBgA8ZrpLqmoVRgxD8moCTJpB_52ngFaJnW5JIflrzpHe09WcmbRqiHIdWQZE9kQgU=@protonmail.com> <87tth1xm4n.fsf@gmail.com> <87msmtxkpy.fsf@gmail.com> <87ed85xj67.fsf@gmail.com> <8734olxcdj.fsf@gmail.com> <87bk2xweng.fsf@gmail.com> <86plrdgxoq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16363"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: gerd.moellmann@gmail.com, pipcet@protonmail.com, yantar92@posteo.net, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 16 18:30:23 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sTl4J-00047a-7v for ged-emacs-devel@m.gmane-mx.org; Tue, 16 Jul 2024 18:30:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sTl2M-0001ql-34; Tue, 16 Jul 2024 12:28:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTl1H-0006VB-Bs for emacs-devel@gnu.org; Tue, 16 Jul 2024 12:27:18 -0400 Original-Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sTl1E-0006bX-Oe; Tue, 16 Jul 2024 12:27:14 -0400 Original-Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-52ea7d2a039so6001384e87.3; Tue, 16 Jul 2024 09:27:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721147229; x=1721752029; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Hi69TQQfKPxWVuNet7iTNCoZ54ZpdRTIjCQ2i9L/VDU=; b=Z/PmFr4Rc3aZ1LtEceAMs/BqCCWI0hpqZEFdWovw+gj61lwHYNBBEHY2tQrA2hTzDT IAG5LdyepINKHrH7NDrYXYiMrcywMltpRmVHb+x2kb8AqURLHIGpLp3TkFGmcULsRoJY KVLGTlSOFgw5D35TNER98wQpwq/XV72MljcwSHrSh/WifEP0+A+HoZplIYpDR75r27EQ Ey49DXcpw43xbdjO0QzWQKdcvROXcEXr73aCLG1kK7L6wmJGKUE9EQsu2cnREL0cg144 Y3/sSxfPSTQxMCs2ojK7JwfOFqq1IlBnf5rOy88630M2Uqwq8yNJrtZw+uWY8OPoHXs2 SBMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721147229; x=1721752029; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Hi69TQQfKPxWVuNet7iTNCoZ54ZpdRTIjCQ2i9L/VDU=; b=GzkkxrAOUN9VF3w9vSv8oL9PSu89kC0iyr0z5h23ty3qHdaW02AjzsEMXDhZEqui3l GpfaEtxvYxft9U/+dO4lkUE7PHVGY0hne3FZjg6T9Tza0pr1KB8A72CWX3KnY9lhiH/P PpuCtDo9dIJqpm9u9XDCZJmC27+xp17tu8/4S3Uy451chd40rUx+puK9geZsfsR3A/pI dqqtyI7Yi3XHvHm0jZuXL/3jFuleK4smHDPw6xyRAdi6piI/RiJjBALrE8pq1Fah+/i7 Ibo1f2okcgsGddu1Uxp0LO1gPSa9sKn0qoZB0X5uWPFXCBzb+C/ims+Z/Yxq4DKe6O0i IPaQ== X-Forwarded-Encrypted: i=1; AJvYcCVPYuCX4RI1BSREjWyaJN9H1bAeh2BaSv9uiA9arYrOB3q3dtqDLkbX2wBkypLobjrLGSdmG1FMocTIuvzS0NG2eHkV X-Gm-Message-State: AOJu0Yxo1/YA8wx/uD4i6IuuICoSxM8qmhI+DWMgErXgbrRtJwGQo6g8 UeydzrBW7mU1uGxoSOO8QW8k6X+qWOzOX9X0cqlgWJ/RA9RM0d5CP1xGng== X-Google-Smtp-Source: AGHT+IFGNC0iSmVjHqjUK8fiAeugQ3oN8/rvmB/802NfvzCSis1RPoE0j4YAIArGpOwJQeVtfLtKbA== X-Received: by 2002:a05:6512:a8d:b0:52e:be30:7e7 with SMTP id 2adb3069b0e04-52edef0fd09mr1788617e87.1.1721147228845; Tue, 16 Jul 2024 09:27:08 -0700 (PDT) Original-Received: from caladan (dialin-234199.rol.raiffeisen.net. [195.254.234.199]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a79bc5a359asm341009266b.19.2024.07.16.09.27.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 09:27:08 -0700 (PDT) In-Reply-To: <86plrdgxoq.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 16 Jul 2024 18:32:05 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::12c; envelope-from=eller.helmut@gmail.com; helo=mail-lf1-x12c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321720 Archived-At: On Tue, Jul 16 2024, Eli Zaretskii wrote: >> +(ert-deftest set-commit-limit-test () >> + (should (equal (igc--set-commit-limit (ash 1 30)) nil)) >> + (should (equal (assoc-string "commit-limit" (igc-info)) >> + '("commit-limit" 1 1073741824 0))) > > Does this work in 32-bit builds? The number 1073741824 overflows > fixnums in such a build. Yes. >> + (should-error (igc--set-commit-limit -1) >> + :type 'args-out-of-range) >> + (should-error (igc--set-commit-limit (- (ash 1 64) 1)) > ^^^^^^^^^^ > As does this. This works too. What doesn't work is (should (equal (igc--set-commit-limit nil) nil)) (should (equal (assoc-string "commit-limit" (igc-info)) '("commit-limit" 1 -1 0))) But that's a bug in igc-info and not in igc--set-commit-limit.