Re: MPS: commit limit

[Helmut Eller <eller.helmut@gmail.com>]

On Tue, Jul 16 2024, Eli Zaretskii wrote:

>> +(ert-deftest set-commit-limit-test ()
>> +  (should (equal (igc--set-commit-limit (ash 1 30)) nil))
>> +  (should (equal (assoc-string "commit-limit" (igc-info))
>> +                 '("commit-limit" 1 1073741824 0)))
>
> Does this work in 32-bit builds?  The number 1073741824 overflows
> fixnums in such a build.

Yes.

>> +  (should-error (igc--set-commit-limit -1)
>> +                :type 'args-out-of-range)
>> +  (should-error (igc--set-commit-limit (- (ash 1 64) 1))
>                                              ^^^^^^^^^^
> As does this.

This works too.

What doesn't work is

  (should (equal (igc--set-commit-limit nil) nil))
  (should (equal (assoc-string "commit-limit" (igc-info))
                 '("commit-limit" 1 -1 0)))

But that's a bug in igc-info and not in igc--set-commit-limit.