From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/debbugs b8c84dbe4b: Improve needed advice Date: Fri, 13 Sep 2024 09:16:43 +0200 Message-ID: <87y13wgh0k.fsf@gmx.de> References: <172615161464.14411.6152144440040360858@vcs2.savannah.gnu.org> <20240912143335.15DACC41F2A@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7193"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 13 09:17:28 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sp0Ya-0001mS-00 for ged-emacs-devel@m.gmane-mx.org; Fri, 13 Sep 2024 09:17:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sp0Y3-0004nB-OS; Fri, 13 Sep 2024 03:16:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sp0Y1-0004n2-Ks for emacs-devel@gnu.org; Fri, 13 Sep 2024 03:16:53 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sp0Xz-0007nU-Mc for emacs-devel@gnu.org; Fri, 13 Sep 2024 03:16:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1726211805; x=1726816605; i=michael.albinus@gmx.de; bh=kHsaXa41nSFHi4EblV1/BzImdjBP5hqt1cdJjSQYK78=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=fz7R0fKW9+IaifZVVYOGhP44YNAaXIG8lXOE3VF47OPu5ShDLoZJPLG+ZsjmYf83 PnlUezs1y90OkMJlO9rXgh/vVO4V4R70lAsfrdExa6GoIsPy238UrmGlN0NSv26hx i4LyRxZUE2PQLgLQc1ZedqXAX8NkVg9m9qwvdVSpHCrknu7ExDSkR7VrWpWSno0ne HtoARSMptxO9vPyN46saZhvSgKhOpxvLYdzHIIl1Np1BsyqjjNDF+LS+fdmtIC/qy cNnRChWWue9IpzGT7WaBlUSVBocVjPB0eemObj3+GKENohhPAzRGJdURLSshD8chF V5CinZB5bIsm/8QU3g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N6sn7-1rw47039Sh-00rpFr; Fri, 13 Sep 2024 09:16:45 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 12 Sep 2024 15:52:08 -0400") X-Provags-ID: V03:K1:5jEdMMJAYQYe2QuELR4uFTop/nJggxmznOUEOpW3DHbxfzCBIBI zjnH9IBtPiWuxw8eQOdi4SapTOPPRMl5ypQqv/obDrANnnJjWm6p4mwbxdzTGZtYNAhdwhx DWdaIa5ZnDSwmXeR0QuH7kIF1Ra2/w6PcXve15Nbk6xDS0yodbL6lOkK8R1JG2aqKjM7T6O 8wYYrNDr7mTcN1PWmbzaw== UI-OutboundReport: notjunk:1;M01:P0:k1xWp4x5X5Q=;QlFacvCo6WYjbUJ0+RFxBiGeC5V dFAysgooStWfhottdjIzKPHU+7FxGAsdAoNn9utmu0y0Wyg/MBZ2oWt+vQYiUKoW+u4lSJvu/ fK200/tM8cWh0X6POD6VANuWSXW7hS9L9kz5hZ+EpvgQ4RUooi2/l1SwSXaN0BcH3GSKMXqEV dO+zlWtsx+rDD/GRaA48p6jUimA/df+DTbohIxvHZ9TwGQ8CNPajDGJofiwcDwdNzjQ//ZZZT OJ5rfkVgpOhOw+U9skJV8MyJemH890+EXB6gKprJsEYwaLshash72LXufcsPHRc5HvMfzAEVC +kq2lV9d/NsC5HbIluKsG+pduEOQFoOsNQlJYnWG3ZuB38pr+2ovHN4ZIe8Sw+DUOtUwu0bUs QLOCoskEGKWdlgZzNKfa1oykKo8cfUuYdy6vQLZ1Tb/K7IhcrZDqCXgVBK42Qy2Kku0stL65q 91LqZDC5t+GIHrck3Q/vF1XLpiWWDCi99u4bruSEaM2faf48Yz4A+qiYlMP8cBSa9eXfhE6zk dP0VjwLxklmLNIh2slUl8MOlW78FoazgoPPk5RQBNdGI812GNwwDQgSOKmJGThGs2NsbRBnGK 3kFHr3OVJhSio548W3l4GSrUV9UGLwv601oI5zr+i5rG+K33QaDkpxs6x2w49Or+rNabW0dyp w9Q3ZtUHvVxhxxtW6da5BizRrcOJ/wtW9f92JyGsVO6BakXtrNlDYbLQqTLFpG3inNmBV0VAP 7SzPhKZ2L+Po1K9dHnni4tJYM+84/cYIMM0zdPcD7tG2dcJz/LiPcRCjBUrTE5/sHDfYQVsV Received-SPF: pass client-ip=212.227.15.19; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323576 Archived-At: Stefan Monnier writes: > Hi Michael, Hi Stefan, >> +(defun debbugs-soap-invoke (operation-name &rest parameters) >> + "Invoke the SOAP connection. >> +OPERATION-NAME and PARAMETERS are as described in `soap-invoke'." >> + (debbugs-compat-add-debbugs-advice) >> + (prog1 >> + (apply #'soap-invoke operation-name parameters) >> + (debbugs-compat-remove-debbugs-advice))) > > I wonder you're doing it this way instead of the "more obvious": > > (defun debbugs-soap-invoke (operation-name &rest parameters) > "Invoke the SOAP connection. > OPERATION-NAME and PARAMETERS are as described in `soap-invoke'." > (let ((url-http-attempt-keepalives nil)) > (apply #'soap-invoke operation-name parameters))) Because it doesn't work? soap-invoke-internal binds url-http-attempt-keepalives to t, which is a problem in a threaded function. See comment in debbugs-compat.el. See also bug#73199 for the resulting error. > - Stefan Best regards, Michael.