From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Reconsider defaults for use-package-vc-prefer-newest Date: Sat, 21 Sep 2024 14:31:21 +0000 Message-ID: <87y13lhydi.fsf@posteo.net> References: <87wmj7dftf.fsf@posteo.net> <87setvxyt6.fsf@gmail.com> <87jzf7o13b.fsf@posteo.net> <87frpvo06a.fsf@posteo.net> <86y13m7swd.fsf@gnu.org> <87bk0inyr1.fsf@posteo.net> <86zfo25nxf.fsf@gnu.org> <87o74im4y8.fsf@posteo.net> <86jzf55vhv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16443"; mail-complaints-to="usenet@ciao.gmane.io" Cc: suhailsingh247@gmail.com, meedstrom@runbox.eu, emacs-devel@gnu.org, tonyzorman@mailbox.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 21 16:32:13 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ss19g-000492-UR for ged-emacs-devel@m.gmane-mx.org; Sat, 21 Sep 2024 16:32:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ss191-0006KX-Fk; Sat, 21 Sep 2024 10:31:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ss18z-0006KP-6j for emacs-devel@gnu.org; Sat, 21 Sep 2024 10:31:29 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ss18v-0001fY-OB for emacs-devel@gnu.org; Sat, 21 Sep 2024 10:31:27 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id E030A240028 for ; Sat, 21 Sep 2024 16:31:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1726929082; bh=JtqFkFe78VFUHp0J3x7K0nZO6PXAaDwMXaNup2vUTbs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=lj7AXMnajJBvNqa/DoACQ17gA6Yh88QacCvRJ0+Wpfjmn3H47RvAfz7krj5vrUY7p +SjWhh3kGqfH0BV//+G8nmfefYLXAOM2gWiq5AQQYW3hgsdppM+rbR0P8DEdYgA+Fa gahzI+vDZcTSChLiwbMG+GbAszdRH42NU4MWORcxGvHFJ7VQSga7QaJGEplCflstsr bDLA2+ViM446crR4hfVhJnOTZLGubNAKL+6LNAwpkdv4nxGxNaXxMgw8KMsIW3+pI0 krmKPc0cUJQ+n+PclmjuyejMNbaPJkPYl5C/9DfXAnoL2gL6AJK0mnEn3hIzG83VE7 5us1lsUedJWDg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4X9sBd6T2Cz6txx; Sat, 21 Sep 2024 16:31:21 +0200 (CEST) In-Reply-To: <86jzf55vhv.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 21 Sep 2024 10:14:20 +0300") X-Hashcash: 1:20:240921:meedstrom@runbox.eu::yj1G1AMAJivEGVnL:UkQ X-Hashcash: 1:20:240921:emacs-devel@gnu.org::txOkriyqsf+44m06:0aWO X-Hashcash: 1:20:240921:eliz@gnu.org::fzFED8Nom3+mTtAY:2sfO X-Hashcash: 1:20:240921:tonyzorman@mailbox.org::OrAWw/WlcApEo8Oo:2RVM X-Hashcash: 1:20:240921:suhailsingh247@gmail.com::6xRu4+INdW1LQ+yY:QZT0 Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323891 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: suhailsingh247@gmail.com, meedstrom@runbox.eu, emacs-devel@gnu.org, >> tonyzorman@mailbox.org >> Date: Fri, 20 Sep 2024 20:43:27 +0000 >> >> Eli Zaretskii writes: >> >> >> From: Philip Kaludercic >> >> Cc: suhailsingh247@gmail.com, meedstrom@runbox.eu, emacs-devel@gnu.org, >> >> tonyzorman@mailbox.org >> >> Date: Fri, 20 Sep 2024 15:14:26 +0000 >> >> >> >> Eli Zaretskii writes: >> >> >> >> >> This is the fix: >> >> > >> >> > Can you explain in plain English what this does? >> >> >> >> Sure, each package has a description object (search for "(cl-defstruct >> >> (package-desc" in package.el), with some fixed attributes like name, >> >> version, dependencies and others that are stored in an alist. The >> >> commit used to create a package is one such attribute stored in the >> >> "extras" slot of a package-desc. My chance modifies the package >> >> description given by the ELPA server and updates the :commit field to >> >> store the commit that was checked out when the package was built >> >> locally. I hope that is clear enough? >> > >> > Yes, thanks. What was the :commit field storing before the change? >> >> The commit the ELPA build server used to release a new version of the >> package. > > That is not right, I agree. > >> M-x list-packages lists the commit of the local checkout for >> VC packages, btw. > > What is "the local checkout" in this context? The checkout of the VC package that the *Help* buffer is describing. >> I could have sworn that M-x describe-package did the same. > > Shouldn't they all be consistent in what commit they show? Yes, that is my point. But since the commit in the package description is not updated when the package is installed, there is a discrepancy. -- Philip Kaludercic on icterid