unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: Highlight opening parentheses in show-paren-mode
       [not found] <16498.10922.341895.425180@priss.frightenedpiglet.com>
@ 2004-04-07 17:46 ` Richard Stallman
  2004-04-13 11:35   ` Juri Linkov
  2004-04-13 11:38   ` Juri Linkov
  0 siblings, 2 replies; 3+ messages in thread
From: Richard Stallman @ 2004-04-07 17:46 UTC (permalink / raw)
  Cc: emacs-devel

	When at the beginning of a valid parenthetical expression,
    SHOW-PAREN-FUNCTION in "paren.el" does not highlight the opening
    parenthesis.

The cursor normally highlights the open paren in that case.
It would look bad to put other highlighting on it.
However, it seems you use the bar cursor.  With the bar cursor,
this change would make sense.

Maybe we should test the cursor type there.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Highlight opening parentheses in show-paren-mode
  2004-04-07 17:46 ` Highlight opening parentheses in show-paren-mode Richard Stallman
@ 2004-04-13 11:35   ` Juri Linkov
  2004-04-13 11:38   ` Juri Linkov
  1 sibling, 0 replies; 3+ messages in thread
From: Juri Linkov @ 2004-04-13 11:35 UTC (permalink / raw)
  Cc: sand, emacs-devel

Richard Stallman <rms@gnu.org> writes:
> 	When at the beginning of a valid parenthetical expression,
>     SHOW-PAREN-FUNCTION in "paren.el" does not highlight the opening
>     parenthesis.
>
> The cursor normally highlights the open paren in that case.
> It would look bad to put other highlighting on it.
> However, it seems you use the bar cursor.  With the bar cursor,
> this change would make sense.
>
> Maybe we should test the cursor type there.

I don't think it looks bad even with the box cursor.  Some arguments:

1. The open paren is already highlighted if mismatched.
Nobody complained that it's bad.

2. It looks more correct if both parens are highlighted in the same
color (even if the color of the open paren under the cursor is reversed).

3. Currently, when the cursor is moved from the closeparen to the
openparen (e.g. by backward-sexp), then for a short time before the
overlay gets deleted, the cursor is highlighted in show-paren color,
and then after a small delay the color is switched to the cursor color.
Such blinking looks bad.  It would be better if the open paren was
always highlighted in show-paren color.

-- 
Juri Linkov
http://www.jurta.org/emacs/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Highlight opening parentheses in show-paren-mode
  2004-04-07 17:46 ` Highlight opening parentheses in show-paren-mode Richard Stallman
  2004-04-13 11:35   ` Juri Linkov
@ 2004-04-13 11:38   ` Juri Linkov
  1 sibling, 0 replies; 3+ messages in thread
From: Juri Linkov @ 2004-04-13 11:38 UTC (permalink / raw)
  Cc: emacs-devel

BTW, this reminds me about another problem.  Saving the region into
the kill ring has a delay for showing the position of the mark.  This
delay is always 1 sec and can't be changed.  Instead of introducing a
new variable for this delay it makes sense to use a related variable
blink-matching-delay.  I think users customized this variable for
the delay to show a matching paren would prefer the same value
for the delay to show a mark position:

diff -u -r1.634 simple.el
--- emacs/lisp/simple.el	25 Mar 2004 16:01:37 -0000	1.634
+++ emacs/lisp/simple.el	13 Apr 2004 11:48:09 -0000
@@ -2013,7 +2013,7 @@
 	      ;; Swap point and mark.
 	      (set-marker (mark-marker) (point) (current-buffer))
 	      (goto-char other-end)
-	      (sit-for 1)
+	      (sit-for blink-matching-delay)
 	      ;; Swap back.
 	      (set-marker (mark-marker) other-end (current-buffer))
 	      (goto-char opoint)

-- 
Juri Linkov
http://www.jurta.org/emacs/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-04-13 11:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <16498.10922.341895.425180@priss.frightenedpiglet.com>
2004-04-07 17:46 ` Highlight opening parentheses in show-paren-mode Richard Stallman
2004-04-13 11:35   ` Juri Linkov
2004-04-13 11:38   ` Juri Linkov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).