From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: (tramp-handleverify-visited-file-modtime Date: Sun, 25 Jul 2004 13:00:10 +0200 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: <87wu0sfj2d.fsf@gmx.de> References: <200407111634.i6BGYpw11715@raven.dms.auburn.edu> <87acxpjla1.fsf@gmx.de> <200407250211.i6P2B1j28553@raven.dms.auburn.edu> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1090753251 17028 80.91.224.253 (25 Jul 2004 11:00:51 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 25 Jul 2004 11:00:51 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 25 13:00:44 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BogkF-0006Xa-00 for ; Sun, 25 Jul 2004 13:00:44 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BognE-0002nr-OD for ged-emacs-devel@m.gmane.org; Sun, 25 Jul 2004 07:03:48 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Bogn9-0002nl-1r for emacs-devel@gnu.org; Sun, 25 Jul 2004 07:03:43 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Bogn7-0002nY-IN for emacs-devel@gnu.org; Sun, 25 Jul 2004 07:03:42 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bogn7-0002nV-Di for emacs-devel@gnu.org; Sun, 25 Jul 2004 07:03:41 -0400 Original-Received: from [213.165.64.20] (helo=mail.gmx.net) by monty-python.gnu.org with smtp (Exim 4.34) id 1Bogjl-0005Lo-Ti for emacs-devel@gnu.org; Sun, 25 Jul 2004 07:00:14 -0400 Original-Received: (qmail 4577 invoked by uid 65534); 25 Jul 2004 11:00:11 -0000 Original-Received: from pD9E70676.dip0.t-ipconnect.de (EHLO magdalene.local) (217.231.6.118) by mail.gmx.net (mp015) with SMTP; 25 Jul 2004 13:00:11 +0200 X-Authenticated: #3708877 Original-To: Luc Teirlinck In-Reply-To: <200407250211.i6P2B1j28553@raven.dms.auburn.edu> (Luc Teirlinck's message of "Sat, 24 Jul 2004 21:11:01 -0500 (CDT)") User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:25941 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25941 Luc Teirlinck writes: > Actually, I recommend the following patch to the present Tramp CVS > version (not the Emacs CVS version) of tramp.el. The reason is that > we want to return t for a file that does not exist according to > `file-attributes' _and_ for which (visited-file-modtime) returns -1, > but nil if `file-attributes' returns nil and `visited-file-modtime' > returns a "real" modtime (neither 0 nor -1), meaning the file _did_ > exist the last time we checked, but has been deleted in the meantime. Sounds OK to me. I've committed the patch to Tramp CVS. Please note that it is visible in the branch "branch-2-0-stable" only, because I'll commit later a bigger update to the trunk which is not intended for Emacs 21.4 (but your patch will be included there, too). > To be completely consistent with `verify-visited-file-modtime' we > should also return nil if the file system could not handle the file > name because it was too long (never happens on the GNU system) or > because there were too many symbolic links to follow. I do not know > whether this case is important enough to worry about. (The patch > below does not.) How were we even able to visit the file in the first > place in such a situation? Maybe we can ignore this situation for the time being. Tramp is based on external programs, which should report an error these cases. Tramp won't distinguish the reason of such errors. Best regards, Michael.