From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel,gmane.emacs.w3m Subject: Re: bogus change(s) in cl-macs.el Date: Fri, 19 Nov 2004 00:40:27 -0500 Message-ID: <87wtwijuh3.fsf-monnier+emacs@gnu.org> References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1100842862 24177 80.91.229.6 (19 Nov 2004 05:41:02 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 19 Nov 2004 05:41:02 +0000 (UTC) Cc: emacs-w3m@namazu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 19 06:40:49 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CV1Vp-0005uL-00 for ; Fri, 19 Nov 2004 06:40:49 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CV1eh-0008H7-H7 for ged-emacs-devel@m.gmane.org; Fri, 19 Nov 2004 00:49:59 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CV1eb-0008Gk-5r for emacs-devel@gnu.org; Fri, 19 Nov 2004 00:49:53 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CV1ea-0008GF-M2 for emacs-devel@gnu.org; Fri, 19 Nov 2004 00:49:52 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CV1ea-0008GB-FF for emacs-devel@gnu.org; Fri, 19 Nov 2004 00:49:52 -0500 Original-Received: from [209.226.175.188] (helo=tomts25-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CV1VT-0000Ep-SA for emacs-devel@gnu.org; Fri, 19 Nov 2004 00:40:28 -0500 Original-Received: from alfajor ([67.71.119.192]) by tomts25-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20041119054026.SAOE25979.tomts25-srv.bellnexxia.net@alfajor>; Fri, 19 Nov 2004 00:40:26 -0500 Original-Received: by alfajor (Postfix, from userid 1000) id 34007D73A2; Fri, 19 Nov 2004 00:40:27 -0500 (EST) Original-To: emacs-devel@gnu.org In-Reply-To: (Katsumi Yamaoka's message of "Fri, 19 Nov 2004 12:06:35 +0900") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:30069 gmane.emacs.w3m:4547 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:30069 > First of all, I protest strongly that such a big change has not > been recorded on the ChangeLog file. The ChangeLog is somewhere, but as usual I forgot to commit it at the time and now I'm working on another computer. But trust me, it's not lost. > *** cl-macs.el~ Tue Nov 16 21:54:14 2004 > --- cl-macs.el Fri Nov 19 01:30:39 2004 > *************** > *** 1314,1320 **** > \(fn ((FUNC ARGLIST BODY...) ...) FORM...)" > (let ((vars nil) (sets nil) (cl-macro-environment cl-macro-environment)) > (while bindings > ! (let ((var (make-symbol "--cl-var--"))) > (push var vars) > (push (list 'function* (cons 'lambda (cdar bindings))) sets) > (push var sets) > --- 1314,1320 ---- > \(fn ((FUNC ARGLIST BODY...) ...) FORM...)" > (let ((vars nil) (sets nil) (cl-macro-environment cl-macro-environment)) > (while bindings > ! (let ((var (gensym))) > (push var vars) > (push (list 'function* (cons 'lambda (cdar bindings))) sets) > (push var sets) It's odd that such a change would fix/break some code. After all `gensym' is more or less doing (make-symbol (concat "G" (random))), so other than the symbol's name, nothing is changed. And since the symbol is uninterned, its name is mostly irrelevant, unless some code later on uses `symbol-name' or does a print+read without using print-gensym. Maybe we'll indeed have to revert to gensym here, but I'd like to first better understand the problem. Could you give us a recipe to reproduce the problem, and a backtrace if applicable. Of course, ideally the recipe should not use emacs-w3m, but as a first step it would still help to see a recipe and a description of the resulting problem. Stefan