From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-w3m@namazu.org
Subject: Re: bogus change(s) in cl-macs.el
Date: Fri, 19 Nov 2004 00:40:27 -0500 [thread overview]
Message-ID: <87wtwijuh3.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <b9y4qjmwn9g.fsf@jpl.org> (Katsumi Yamaoka's message of "Fri, 19 Nov 2004 12:06:35 +0900")
> First of all, I protest strongly that such a big change has not
> been recorded on the ChangeLog file.
The ChangeLog is somewhere, but as usual I forgot to commit it at the time
and now I'm working on another computer. But trust me, it's not lost.
> *** cl-macs.el~ Tue Nov 16 21:54:14 2004
> --- cl-macs.el Fri Nov 19 01:30:39 2004
> ***************
> *** 1314,1320 ****
> \(fn ((FUNC ARGLIST BODY...) ...) FORM...)"
> (let ((vars nil) (sets nil) (cl-macro-environment cl-macro-environment))
> (while bindings
> ! (let ((var (make-symbol "--cl-var--")))
> (push var vars)
> (push (list 'function* (cons 'lambda (cdar bindings))) sets)
> (push var sets)
> --- 1314,1320 ----
> \(fn ((FUNC ARGLIST BODY...) ...) FORM...)"
> (let ((vars nil) (sets nil) (cl-macro-environment cl-macro-environment))
> (while bindings
> ! (let ((var (gensym)))
> (push var vars)
> (push (list 'function* (cons 'lambda (cdar bindings))) sets)
> (push var sets)
It's odd that such a change would fix/break some code.
After all `gensym' is more or less doing (make-symbol (concat "G"
(random))), so other than the symbol's name, nothing is changed.
And since the symbol is uninterned, its name is mostly irrelevant, unless
some code later on uses `symbol-name' or does a print+read without using
print-gensym.
Maybe we'll indeed have to revert to gensym here, but I'd like to first
better understand the problem.
Could you give us a recipe to reproduce the problem, and a backtrace
if applicable. Of course, ideally the recipe should not use emacs-w3m,
but as a first step it would still help to see a recipe and a description of
the resulting problem.
Stefan
prev parent reply other threads:[~2004-11-19 5:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-19 3:06 bogus change(s) in cl-macs.el Katsumi Yamaoka
2004-11-19 3:41 ` Luc Teirlinck
2004-11-19 3:51 ` Miles Bader
2004-11-19 4:21 ` Luc Teirlinck
2004-11-19 3:48 ` Miles Bader
2004-11-19 3:59 ` Katsumi Yamaoka
2004-11-19 5:55 ` [emacs-w3m:07185] " Katsumi Yamaoka
2004-11-19 7:10 ` Stefan Monnier
2004-11-19 20:04 ` Richard Stallman
2004-11-26 2:17 ` Katsumi Yamaoka
2004-11-26 4:03 ` Stefan Monnier
2004-11-26 5:18 ` Katsumi Yamaoka
2004-11-26 23:51 ` Stefan Monnier
2004-11-19 5:40 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wtwijuh3.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-w3m@namazu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).