Other problem in Themes.

Other problem in Themes.

[Luc Teirlinck]

(emacs)Custom Themes contains the sentence:

      You can load the themes you've previously defined with the command
   `load-theme'.  It prompts for a theme name in the minibuffer, then
   loads that theme if it isn't already loaded.

I believe that in an earlier discussion of Custom Themes (several
months ago), we decided that load-theme should _unconditionally_ load
themes, otherwise bugs resulted.  I believe that this was why the name
of the command was changed from require-theme to load-theme.  Either
the "if it isn't already loaded" part of the above quote is false,
or else the old bugs are probably still present (or reintroduced).

Sincerely,

Luc.

Re: Other problem in Themes.

[Chong Yidong]

>       You can load the themes you've previously defined with the command
>    `load-theme'.  It prompts for a theme name in the minibuffer, then
>    loads that theme if it isn't already loaded.
>
> Either the "if it isn't already loaded" part of the above quote is
> false,

Yes, that was clearly a mistake.  I fixed that.

Re: Other problem in Themes.

[Richard M. Stallman]

    I believe that in an earlier discussion of Custom Themes (several
    months ago), we decided that load-theme should _unconditionally_ load
    themes, otherwise bugs resulted.

ISTR that that was meant to solve problems about order of priority
of settings in various themes.  I solved those problems in 
a different way, by writing custom-theme-recalc-variable etc.
As far as I know, there is no reason for this any more.

    > Either the "if it isn't already loaded" part of the above quote is
    > false,

    Yes, that was clearly a mistake.  I fixed that.

I think it was not a mistake.  load-theme calls require,
and require doesn't load the file if it was already loaded.