[id.brep@gmail.com: Strange behavior of emacs-lisp-mode with outline-minor-mode]

[id.brep@gmail.com: Strange behavior of emacs-lisp-mode with outline-minor-mode]

[Richard Stallman]

Does anyone disagree with this change?
It is really a matter of what outline commands should do in Lisp mode,
and I don't use them.

------- Start of forwarded message -------
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com;
	h=received:to:subject:from:date:message-id:user-agent:mime-version:content-type;
	b=fJAxfaRpRWx1MXRB+xzUNsLJg1QRsAJNWzI8L3csmFYNTFXVlN6L8XuxKy/GE9oJ/hz6OVPIuALbhwRvP3AUpCNPmcEeufwrk3CRmXRPkhu6oRWrZYxBdfE+FyNF0ZPIE9+dWb7Kg42Z1vfkjLVcmKnJngGEIj8bVLwC00DIDEE=
To: emacs-pretest-bug@gnu.org
From: Zhang Wei <id.brep@gmail.com>
Date: Wed, 01 Mar 2006 01:08:40 +0800
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Strange behavior of emacs-lisp-mode with outline-minor-mode

If we turn on outline-minor-mode in emacs-lisp-mode, and press
`C-c @ C-q', only three dots there, nothing left!

Accoding to the doc of `C-c @ C-q' runs the command
`hide-sublevels', it should hide everything but the top levels
levels of headers, in whole buffer.

The value of outline-regexp of emacs-lisp-mode is 

";;;\\(;* [^ 	\n]\\|###autoload\\)\\|("

That means every line start with a "(" or ";;; x" will be
considered as top level headers. When we run `hide-sublevels',
these lines shouled be left.

This bug could be fixed by the following patch:

- --8<---------------cut here---------------start------------->8---
- --- orig/lisp/emacs-lisp/lisp-mode.el
+++ mod/lisp/emacs-lisp/lisp-mode.el
@@ -251,9 +251,11 @@
 (defun lisp-outline-level ()
   "Lisp mode `outline-level' function."
   (let ((len (- (match-end 0) (match-beginning 0))))
- -    (if (looking-at "(\\|;;;###autoload")
+    (if (looking-at ";;;###autoload")
 	1000
- -      len)))
+      (if (looking-at "(") 
+	  1
+	(- len 4)))))
 
 (defvar lisp-mode-shared-map
   (let ((map (make-sparse-keymap)))
- --8<---------------cut here---------------end--------------->8---


_______________________________________________
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
------- End of forwarded message -------

Re: Fwd: Strange behavior of emacs-lisp-mode with outline-minor-mode

[Stefan Monnier]

> Does anyone disagree with this change?
> It is really a matter of what outline commands should do in Lisp mode,
> and I don't use them.

>    (let ((len (- (match-end 0) (match-beginning 0))))
> - -    (if (looking-at "(\\|;;;###autoload")
> +    (if (looking-at ";;;###autoload")
>  	1000
> - -      len)))
> +      (if (looking-at "(") 
> +	  1
> +	(- len 4)))))
 
This means that

 ;;; Foo:

gets level 1 and that

 (defun ...)

also gets level 1.  This is wrong.

The motivation for this change was:

> If we turn on outline-minor-mode in emacs-lisp-mode, and press
> `C-c @ C-q', only three dots there, nothing left!

I don't see this behavior.  Please give a precise recipe.


        Stefan

Re: Fwd: Strange behavior of emacs-lisp-mode with outline-minor-mode

[Zhang Wei]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> This means that
>
>  ;;; Foo:
>
> gets level 1 and that
>
>  (defun ...)
>
> also gets level 1.  This is wrong.

Then what is right? Gets level 1000 is right?
The problem is there's no level 1 in lisp-mode with outline-minor.

> The motivation for this change was:
>
>> If we turn on outline-minor-mode in emacs-lisp-mode, and press
>> `C-c @ C-q', only three dots there, nothing left!
>
> I don't see this behavior.  Please give a precise recipe.

1, emacs -q
2, C-x C-f emacs-source/lisp/ido.el
3, C-c @ C-q

Re: Fwd: Strange behavior of emacs-lisp-mode with outline-minor-mode

[Stefan Monnier]

>> This means that
>> 
>> ;;; Foo:
>> 
>> gets level 1 and that
>> 
>> (defun ...)
>> 
>> also gets level 1.  This is wrong.

> Then what is right?

Something else where the level of "(" is higher than for ";;; ".

> Gets level 1000 is right?

For example.

> The problem is there's no level 1 in lisp-mode with outline-minor.

Actually, I think the problem is that outline doesn't really define what
levels mean.  At least various major modes use different values.

For most cases outline doesn't care about absolute values of levels but only
relative ones.  C-x @ C-q is the only counter example I've bumped into
(there are probably others, tho).  I think the expectation was that the user
provide an explicit numeric argument when using it, rather than rely on
the default.

>> The motivation for this change was:
>> 
>>> If we turn on outline-minor-mode in emacs-lisp-mode, and press
>>> `C-c @ C-q', only three dots there, nothing left!
>> 
>> I don't see this behavior.  Please give a precise recipe.

> 1, emacs -q
> 2, C-x C-f emacs-source/lisp/ido.el
> 3, C-c @ C-q

Oops, sorry, yes I see it now.  It turns out I've been using the patch below
for so long that I completely forgot about it.  I've just installed it.


        Stefan


--- orig/lisp/outline.el
+++ mod/lisp/outline.el
@@ -828,7 +829,13 @@
 
 (defun hide-sublevels (levels)
   "Hide everything but the top LEVELS levels of headers, in whole buffer."
-  (interactive "p")
+  (interactive (list
+		(cond
+		 (current-prefix-arg (prefix-numeric-value current-prefix-arg))
+		 ((save-excursion (beginning-of-line)
+				  (looking-at outline-regexp))
+		  (funcall outline-level))
+		 (t 1))))
   (if (< levels 1)
       (error "Must keep at least one level of headers"))
   (let (outline-view-change-hook)

Re: Fwd: Strange behavior of emacs-lisp-mode with outline-minor-mode

[Zhang Wei]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Oops, sorry, yes I see it now.  It turns out I've been using the patch below
> for so long that I completely forgot about it.  I've just installed it.

This patch works great.