Proposal: ibuffer-do-view should not delete other windows

Proposal: ibuffer-do-view should not delete other windows

[Tassilo Horn]

Hi all,

I propose to remove the call to `delete-other-windows' from
`ibuffer-do-view-1'.  I think that's much more sensible, especially with
today's wide screen.

I use emacs in fullscreen mode most of the time and it's split
horizontally, so that I have two side-by-side windows.  When I invoke
`ibuffer', mark some buffers and hit `v' (`ibuffer-do-view') I want it
to split the current window vertically, but it shouldn't destroy my
window configuration.  (There's no sense in having 3 vertical windows
where each is more than 160 columns wide in the general case.)

If someone likes the current behavior I don't see a big problem doing a
`C-x 1' before calling `ibuffer'.

What do others think?

--8<---------------cut here---------------start------------->8---
Index: lisp/ibuffer.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/ibuffer.el,v
retrieving revision 1.87
diff -u -r1.87 ibuffer.el
--- lisp/ibuffer.el	13 Aug 2007 13:41:02 -0000	1.87
+++ lisp/ibuffer.el	15 Aug 2007 09:11:16 -0000
@@ -1110,7 +1110,6 @@
 		 (not (y-or-n-p (format "Really create a new frame for %s buffers? "
 					(length marked-bufs)))))
       (set-buffer-modified-p nil)
-      (delete-other-windows)
       (switch-to-buffer (pop marked-bufs))
       (let ((height (/ (1- (if (eq type 'horizontally) (frame-width)
 			     (frame-height)))
Index: lisp/ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.11551
diff -u -r1.11551 ChangeLog
--- lisp/ChangeLog	15 Aug 2007 03:09:04 -0000	1.11551
+++ lisp/ChangeLog	15 Aug 2007 09:11:22 -0000
@@ -1,3 +1,7 @@
+2007-08-15  Tassilo Horn  <tassilo@member.fsf.org>
+
+	* ibuffer.el (ibuffer-do-view-1): Don't call `delete-other-windows'.
+
 2007-08-15  Glenn Morris  <rgm@gnu.org>
 
 	* mail/undigest.el (rmail-digest-parse-rfc1153sloppy): Be even
--8<---------------cut here---------------end--------------->8---

Bye,
Tassilo