From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bastien Newsgroups: gmane.emacs.devel Subject: Re: bookmark.el and lisp/gnus/gnus-bookmark.el Date: Fri, 07 Mar 2008 12:23:58 +0000 Message-ID: <87wsoe3eox.fsf@bzg.ath.cx> References: <874pbj682f.fsf@red-bean.com> <87zltbhbq8.fsf@bzg.ath.cx> <87iqzzigv6.fsf@bzg.ath.cx> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1204892659 19643 80.91.229.12 (7 Mar 2008 12:24:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 7 Mar 2008 12:24:19 +0000 (UTC) Cc: Tassilo Horn , Stefan Monnier , Reiner Steib , emacs-devel@gnu.org To: Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 07 13:24:45 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JXbcy-0008Ju-D3 for ged-emacs-devel@m.gmane.org; Fri, 07 Mar 2008 13:24:44 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JXbcQ-0005Ru-MB for ged-emacs-devel@m.gmane.org; Fri, 07 Mar 2008 07:24:10 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JXbcN-0005R4-Hg for emacs-devel@gnu.org; Fri, 07 Mar 2008 07:24:07 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JXbcM-0005PD-1e for emacs-devel@gnu.org; Fri, 07 Mar 2008 07:24:07 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JXbcL-0005P1-So for emacs-devel@gnu.org; Fri, 07 Mar 2008 07:24:05 -0500 Original-Received: from nf-out-0910.google.com ([64.233.182.189]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JXbcL-0007SX-E3 for emacs-devel@gnu.org; Fri, 07 Mar 2008 07:24:05 -0500 Original-Received: by nf-out-0910.google.com with SMTP id f5so242725nfh.26 for ; Fri, 07 Mar 2008 04:24:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:received:from:to:cc:subject:in-reply-to:references:user-agent:date:message-id:mime-version:content-type:sender; bh=v1ldmhqoop5EBARA/vTN1gQxGUt3WqVtM3k3c3Ioe6M=; b=SCWqgyXlbzXzloCzw9ck2nhVSbALA/WNLnf2LhR2sY6sXXn6PshdLR3ktG+A3lasa98xanZEPHfEPOGItnqaUXU6j2eBg5WWp6O/zN1AQu7g7Gor9AARZTdZFn1LuH/MfQbMIA5iszhbbyKG2hx2jZvsFGDVmveJYeiw11bbZ5E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date:message-id:mime-version:content-type:sender; b=HOncLNDengELHyESfSNV5E58T+f0c6dFRFlO0VZ5CtCePtK4RhiBA6WF1jXijCcqp2RkyxTX/7YfoAXM3tYyy2Bf+NeG+2fz5cY9gCXAmiitsY2guihjgZThQnlOon2r8w3Ml+7MUzorlg85qSYMpH2LSGg3VTHRGFFlNcg3Ofw= Original-Received: by 10.78.132.2 with SMTP id f2mr3509617hud.37.1204892642487; Fri, 07 Mar 2008 04:24:02 -0800 (PST) Original-Received: from bzg.ath.cx ( [81.99.213.34]) by mx.google.com with ESMTPS id z40sm2023888ikz.4.2008.03.07.04.24.00 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 07 Mar 2008 04:24:01 -0800 (PST) Original-Received: by bzg.ath.cx (Postfix, from userid 1000) id EEE40157920; Fri, 7 Mar 2008 12:23:58 +0000 (GMT) In-Reply-To: <87iqzzigv6.fsf@bzg.ath.cx> (Bastien's message of "Thu, 06 Mar 2008 23:15:41 +0000") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:91627 Archived-At: Hi Karl, Bastien writes: > Stefan Monnier writes: > >>> He added the buffer-local variable `bookmark-make-cell-function', which >>> lets you define a handler for a mode: when setting a bookmark, a handler >>> is added to the record and jumping to the bookmark will use this handler >>> instead of `bookmark-jump' (see `bookmark-jump-internal'.) >> >>> This is all good, but it only works for buffer visiting files and >>> Info-mode. >> >> I don't understand why you think so. Could you explain in more >> details? > > This boils down to this: having a `bookmark-make-name-function' doing > for the names of the bookmarks what `bookmark-make-cell-function' does > for the records. This would be locally set depending on the mode we're > in. I can see you've made this change, and used bookmark-make-cell-function instead of bookmark-make-name-function -- can you confirm the change so that I update gnus-bookmark.el accordingly? BTW, maybe `bookmark-make-name-function' should be advertized somewhere in bookmark.el. And PARG argument is not mentionned in bookmark-set. Thanks, -- Bastien