From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Updated project-specific settings patch Date: Tue, 20 May 2008 10:02:28 -0400 Message-ID: <87wslpkr9n.fsf@stupidchicken.com> References: <87hccukqp9.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1211292423 28777 80.91.229.12 (20 May 2008 14:07:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 20 May 2008 14:07:03 +0000 (UTC) Cc: emacs-devel@gnu.org To: Tom Tromey Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 20 16:07:32 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JySUs-0006ym-1o for ged-emacs-devel@m.gmane.org; Tue, 20 May 2008 16:07:22 +0200 Original-Received: from localhost ([127.0.0.1]:55732 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JySU8-0006IT-0A for ged-emacs-devel@m.gmane.org; Tue, 20 May 2008 10:06:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JySU3-0006IC-Ft for emacs-devel@gnu.org; Tue, 20 May 2008 10:06:31 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JySU1-0006Hq-3o for emacs-devel@gnu.org; Tue, 20 May 2008 10:06:30 -0400 Original-Received: from [199.232.76.173] (port=59085 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JySU0-0006Hj-PK for emacs-devel@gnu.org; Tue, 20 May 2008 10:06:28 -0400 Original-Received: from cyd.mit.edu ([18.115.2.24]:43207) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JySU0-0004Fu-AZ for emacs-devel@gnu.org; Tue, 20 May 2008 10:06:28 -0400 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 208074E3B1; Tue, 20 May 2008 10:02:28 -0400 (EDT) In-Reply-To: (Tom Tromey's message of "Mon, 19 May 2008 15:55:06 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97448 Archived-At: Tom Tromey writes: >>>>>> "Chong" == Chong Yidong writes: > > Chong> Could you also write a patch for the Emacs manual? (It doesn't have to > Chong> be ready before you check in the code, but the sooner the better.) > > The patch included a change to doc/emacs/custom.texi. I missed that part of your patch. Sorry for the noise. I've read it now, and have a couple of minor comments. Emacs provides a way to specify local variable values per-directory. This can be done one of two ways. This is confusingly worded: is there "a way" or "two ways"? I suggest changing this to: Directory variables are file-local variables that apply to all the files within a directory. You can define directory variables in two ways. Also, Unsafe directory-local variables are handled in the same way as unsafe file-local variables. You need to be more specific about what happens when the user tries to define unsafe directory-local variables. On another note: does your patch include a enable-directory-variables option, analogous to enable-local-variables, that allows the user to turn off directory variable scanning? If not, maybe should.