From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: emacsclient's option decoding code Date: Sun, 02 Nov 2008 16:45:19 -0500 Message-ID: <87wsflyf80.fsf@cyd.mit.edu> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1225662415 25932 80.91.229.12 (2 Nov 2008 21:46:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 2 Nov 2008 21:46:55 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 02 22:47:57 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kwknd-0007o0-0j for ged-emacs-devel@m.gmane.org; Sun, 02 Nov 2008 22:47:57 +0100 Original-Received: from localhost ([127.0.0.1]:58913 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KwkmW-0004Zc-6o for ged-emacs-devel@m.gmane.org; Sun, 02 Nov 2008 16:46:48 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kwkl4-0003uP-1A for emacs-devel@gnu.org; Sun, 02 Nov 2008 16:45:18 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kwkl0-0003p8-42 for emacs-devel@gnu.org; Sun, 02 Nov 2008 16:45:17 -0500 Original-Received: from [199.232.76.173] (port=54363 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kwkkz-0003p0-TN for emacs-devel@gnu.org; Sun, 02 Nov 2008 16:45:13 -0500 Original-Received: from cyd.mit.edu ([18.115.2.24]:54174) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kwkky-0005UU-RK; Sun, 02 Nov 2008 16:45:12 -0500 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id DDC4457E1BA; Sun, 2 Nov 2008 16:45:19 -0500 (EST) In-Reply-To: (Eli Zaretskii's message of "Sat, 01 Nov 2008 16:04:14 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105271 Archived-At: Eli Zaretskii writes: > I find this code highly confusing to the degree of being > unmaintainable. Look, for example, how it sets `tty' to zero or > non-zero, and how this is interleaved with testing whether it is zero > or non-zero, completely obfuscating the semantics of the code and the > meaning of each variable. > > I think this should be rewritten, but since I cannot make heads or > tails out of it, I cannot do that myself without risking to break the > code. Please someone make this code speak to a programmer. I did what I could to simplify the code (partly by removing the redundant variable window_system, partly by adding comments). Hopefully nothing broke. My testing indicates no problems.