Re: Changes to emacs/lisp/buff-menu.el,v

Re: Changes to emacs/lisp/buff-menu.el,v

[Romain Francoise]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> +(defconst Buffer-menu-short-ellipsis (if (char-displayable-p ?…) "…" ":"))

This breaks bootstrap:

| Loading textmodes/text-mode...
| Loading textmodes/fill...
| ((60987 . 15306) (12539 . 0) (645 . 35) 90741 1300175 (109 . 11) (22 . 13) (5645 . 6325))
| Loading replace...
| Loading buff-menu...
| Attempt to autoload char-displayable-p while preparing to dump
| make[2]: *** [emacs] Error 255
| make[2]: Leaving directory `/srv/buildbot/slave/emacs-trunk/build/src'
| make[1]: *** [src] Error 2
| make[1]: Leaving directory `/srv/buildbot/slave/emacs-trunk/build'
| make: *** [bootstrap] Error 2

http://emacsbuild.orebokech.com/emacs-trunk/builds/1147/step-compile/0

Re: Changes to emacs/lisp/buff-menu.el,v

[Miles Bader]

Romain Francoise <romain@orebokech.com> writes:
>> +(defconst Buffer-menu-short-ellipsis (if (char-displayable-p ?…) "…" ":"))
>
> This breaks bootstrap:
> | Attempt to autoload char-displayable-p while preparing to dump
> | make[2]: *** [emacs] Error 255

... and surely any environmental tests in the initializer of a dumped
variable are obviously wrong anyway...

-Miles

-- 
97% of everything is grunge

Re: Changes to emacs/lisp/buff-menu.el,v

[Glenn Morris]

Miles Bader wrote:

> ... and surely any environmental tests in the initializer of a dumped
> variable are obviously wrong anyway...

And these days, the same Emacs instance can be accessed simultaneously
from displays with different capabilities; so bad form all round really. ;)

Re: Changes to emacs/lisp/buff-menu.el,v

[Stefan Monnier]

>> ... and surely any environmental tests in the initializer of a dumped
>> variable are obviously wrong anyway...
> And these days, the same Emacs instance can be accessed simultaneously
> from displays with different capabilities; so bad form all round really. ;)

Yup... undone.  This said, nowadays, I'd really like to just always
use "…".


        Stefan

Re: Changes to emacs/lisp/buff-menu.el,v

[Juri Linkov]

>>> ... and surely any environmental tests in the initializer of a dumped
>>> variable are obviously wrong anyway...
>> And these days, the same Emacs instance can be accessed simultaneously
>> from displays with different capabilities; so bad form all round really. ;)
>
> Yup... undone.  This said, nowadays, I'd really like to just always
> use "…".

Maybe a function is better:

(defun Buffer-menu-short-ellipsis ()
 (if (char-displayable-p ?…) "…" ":"))

We already do such customization-by-function-redefinition
e.g. in `help-default-arg-highlight'.

-- 
Juri Linkov
http://www.jurta.org/emacs/