unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Tom Tromey <tromey@redhat.com>
Cc: Dan Nicolaescu <dann@ics.uci.edu>,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	emacs-devel@gnu.org
Subject: Re: dir-locals.el take precedence over user's mode-hook changes
Date: Wed, 24 Dec 2008 22:52:55 +0200	[thread overview]
Message-ID: <87wsdpp9q8.fsf@jurta.org> (raw)
In-Reply-To: <m3zlil2u43.fsf@fleche.redhat.com> (Tom Tromey's message of "Wed,  24 Dec 2008 13:31:08 -0700")

> Dan> If the user really really wants to override the settings doesn't
> Dan> rm .dir-locals.el
> Dan> or
> Dan> changing the contents of .dir-locals.el
> Dan> work well enough?
>
> My intent was for projects to check these into version control.
> So, removing them is not always ok.
>
> As I recall you can set up your own local definition for a project to
> override the project's file, though.  This is somewhat inconvenient,
> but it ought to work.

I agree with Stefan that the current order of calling a hook and
setting local variables (either dired-local or file-local) is wrong.

Another problem with the current order is that it is impossible to use
`bug-reference-mode' on ChangeLog files.  We already have a local variable
`bug-reference-url-format' set in Local Variables to the string
"http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=%s"
(BTW, this file-local variable should be moved to .dir-locals.el)

And when I try to enable `bug-reference-mode' using the following hook:

  (add-hook 'change-log-mode-hook 'bug-reference-mode)

it never gets enabled because `bug-reference-mode' tests whether
a variable `bug-reference-url-format' is non-nil before enabling this mode,
and this variable is not yet set because it gets initialized later in
`hack-local-variables'.

-- 
Juri Linkov
http://www.jurta.org/emacs/




  reply	other threads:[~2008-12-24 20:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-24 18:31 dir-locals.el take precedence over user's mode-hook changes Stefan Monnier
2008-12-24 19:03 ` Dan Nicolaescu
2008-12-24 20:31   ` Tom Tromey
2008-12-24 20:52     ` Juri Linkov [this message]
2008-12-30 17:20       ` Stefan Monnier
2008-12-30 23:59         ` Juri Linkov
2008-12-31  1:43           ` Stefan Monnier
2008-12-31  1:54           ` Dan Nicolaescu
2008-12-31 12:28             ` Juri Linkov
2008-12-31 16:17               ` Dan Nicolaescu
2008-12-31 17:27                 ` Stefan Monnier
2008-12-31 21:41                   ` Dan Nicolaescu
2008-12-31 23:50                     ` Chetan Pandya
2009-01-03  0:45                       ` Juri Linkov
2008-12-31 16:39           ` Richard M Stallman
2008-12-25  4:49   ` Miles Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wsdpp9q8.fsf@jurta.org \
    --to=juri@jurta.org \
    --cc=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).