From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: bookmark.el bug report Date: Sat, 02 Jan 2010 09:15:40 +0100 Organization: ThierryVolpiatto Message-ID: <87ws00sz0z.fsf@tux.homenetwork> References: <5065e2900912272219y3734fc9fsdaee41167ef99ad7@mail.gmail.com> <87r5q99jv9.fsf@red-bean.com> <87aawx9jfm.fsf@red-bean.com> <87ljgh2dkc.fsf@tux.homenetwork> <87637l7ys5.fsf@red-bean.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1262421206 7473 80.91.229.12 (2 Jan 2010 08:33:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 2 Jan 2010 08:33:26 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 02 09:33:19 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NQzQD-0007Na-MO for ged-emacs-devel@m.gmane.org; Sat, 02 Jan 2010 09:33:17 +0100 Original-Received: from localhost ([127.0.0.1]:60463 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQzQD-0000Ha-SD for ged-emacs-devel@m.gmane.org; Sat, 02 Jan 2010 03:33:17 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NQzEr-00053t-11 for emacs-devel@gnu.org; Sat, 02 Jan 2010 03:21:33 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NQzEm-000522-3j for emacs-devel@gnu.org; Sat, 02 Jan 2010 03:21:32 -0500 Original-Received: from [199.232.76.173] (port=53847 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQzEl-00051d-6C for emacs-devel@gnu.org; Sat, 02 Jan 2010 03:21:27 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:38838) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NQzEk-0007SX-Se for emacs-devel@gnu.org; Sat, 02 Jan 2010 03:21:27 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.50) id 1NQzEd-0003Gq-Gg for emacs-devel@gnu.org; Sat, 02 Jan 2010 09:21:19 +0100 Original-Received: from 85.77.197-77.rev.gaoland.net ([77.197.77.85]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 02 Jan 2010 09:21:19 +0100 Original-Received: from thierry.volpiatto by 85.77.197-77.rev.gaoland.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 02 Jan 2010 09:21:19 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 42 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 85.77.197-77.rev.gaoland.net Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEUHBARgJRFPS0WbMBTC TSG/uJs0yyVHAAAACXBIWXMAAAsSAAALEgHS3X78AAAACXZwQWcAAAAwAAAAMADO7oxXAAABpUlE QVQ4y3VTQXKDMAyUnD7AwvQOhtxj5N4LFh9ow/+/UtlpM0BczWSS0Wola7UBeEb3+3kJ/5p9ZLz3 UI0n0J0Y4K/lh1nG24FhlJOR2LdSKtpV5gfi/Zd+NdaJBbB4D5N0JnfUIVp6obZURkJwS2a8b9uX AkgxA5gCEcknAH1s2z0DPooWmjGKcJR+HNZt+9bm0GtGRycRuZGs98Ffr02vABWGopIAhmXmxnQN BwBXZjgFLHRoqbfeYxCLWqsjLyKhbEHW+A5nEs699Q2O80ALrgHTmUTy6P0MnKyKQpKHpoNWokxs F0D5VegvWmEozyE6nuMiS98mWzlUQ9bW8qYfqOaFtzWlYCqGeIs6HEyl08jkrxUG9MF5ipXpOOpd ZMoXPPVSLWJiiwNNB+eRSyxJZmQKcacikgucnCRiHuJOLmyYJRDPwOqAvY4pA+Wy+VS8G26BAsdb Ph2Hw7ORy/H0IOG0TnaM8Cp0XrFYyU0v2z8AqkifPVbLZ0qo/gsRg60C7p+8Ov9jrUIxFde+jnAq X42hyp/c+ZcnVyUYBarrqZt3+R8450png3cWKgAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAwOC0wNS0z MVQyMjoxNDoyMiswMjowMK3VBDcAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMDctMTAtMjhUMTc6MDg6 NDgrMDE6MDDLdIcLAAAAEXRFWHRqcGVnOmNvbG9yc3BhY2UAMix1VZ8AAAAgdEVYdGpwZWc6c2Ft cGxpbmctZmFjdG9yADJ4MiwxeDEsMXgxSfqmtAAAAABJRU5ErkJggg== User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1.91 (gnu/linux) Cancel-Lock: sha1:nGexlwW+/i+2Jnbvp3h3IbFUkPo= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:119262 Archived-At: Karl Fogel writes: > Thierry Volpiatto writes: >>There is one bug also in bookmark-bmenu-hide-filenames where you forget >>to put properties on bookmark when rebuilding. >>So after one use of hide-/show-filenames, bookmark-bmenu-bookmark >>doesn't work anymore because bookmark have no properties. >> >>I sent a patch to Stefan. > > I can't reproduce this. Can you please try with the latest bookmark.el > and let me know an exact reproduction recipe, if you can reproduce? It is working, but still fragile if you don't put properties on bookmark when rebuilding in *-hide-filenames. ,----[ bookmark-bmenu-hide-filenames ] | (while bookmark-bmenu-hidden-bookmarks | (move-to-column column t) | (bookmark-kill-line) | (let ((name (pop bookmark-bmenu-hidden-bookmarks)) | (start (point))) | (insert name) | (put-text-property start (point) 'bookmark-name-prop name) | (if (and (display-color-p) (display-mouse-p)) | (add-text-properties | start (point) `---- Also, in the same function,now you have a new variable, there is no need to set column around bookmark title, just set it to this new variable. ,----[ bookmark-bmenu-hide-filenames ] | (let ((inhibit-read-only t) | (column bookmark-bmenu-marks-width)) `---- Why `bookmark-bmenu-marks-width' is set to 1 and not 2? -- A + Thierry Volpiatto Location: Saint-Cyr-Sur-Mer - France