From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: bug in copy-directory Date: Mon, 31 Jan 2011 12:06:13 -0500 Message-ID: <87wrll2ebe.fsf@stupidchicken.com> References: <87ipxaidea.fsf@gmail.com> <87k4hp96g0.fsf@stupidchicken.com> <878vy59ejz.fsf@stupidchicken.com> <87lj23ickn.fsf@stupidchicken.com> <87sjway8i3.fsf@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1296494031 17055 80.91.229.12 (31 Jan 2011 17:13:51 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 31 Jan 2011 17:13:51 +0000 (UTC) Cc: emacs-devel@gnu.org, Stefan Monnier , Thierry Volpiatto To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 31 18:13:45 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PjxJu-0003S9-Lk for ged-emacs-devel@m.gmane.org; Mon, 31 Jan 2011 18:13:42 +0100 Original-Received: from localhost ([127.0.0.1]:51204 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PjxJt-0007Yv-SF for ged-emacs-devel@m.gmane.org; Mon, 31 Jan 2011 12:13:41 -0500 Original-Received: from [140.186.70.92] (port=47442 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PjxCm-0003TG-0f for emacs-devel@gnu.org; Mon, 31 Jan 2011 12:06:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PjxCk-0005dc-OH for emacs-devel@gnu.org; Mon, 31 Jan 2011 12:06:19 -0500 Original-Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]:45640) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PjxCk-0005dF-M7 for emacs-devel@gnu.org; Mon, 31 Jan 2011 12:06:18 -0500 Original-Received: from furball (dhcp128036014143.central.yale.edu [128.36.14.143]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p0VH6Eoj005100 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 31 Jan 2011 12:06:14 -0500 Original-Received: by furball (Postfix, from userid 1000) id 099DD160681; Mon, 31 Jan 2011 12:06:13 -0500 (EST) In-Reply-To: <87sjway8i3.fsf@gmx.de> (Michael Albinus's message of "Sun, 30 Jan 2011 11:46:12 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 130.132.50.146 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135323 Archived-At: Michael Albinus writes: > Your patch breaks recursive copy now. Extend the use case from that bug > report: > > - Create directory /tmp/test > - Create directory /tmp/test/test > - Create file /tmp/test/a > - Create file /tmp/test/test/b > > - Apply (copy-directory "/tmp/test" "~/") > Everything is fine > > - Apply again (copy-directory "/tmp/test" "~/") > The target directory structure is broken. I think I see the problem: the arguments to the recursive call to copy-directory were not taking the "copy as a subdirectory" behavior into account. I've committed a fix.