From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: Killing a frame sometimes kills emacs Date: Thu, 17 Nov 2011 17:58:25 +0100 Message-ID: <87wrayit3i.fsf@tsdh.uni-koblenz.de> References: <87d3flnxoo.fsf@thinkpad.tsdh.de> <83fwkhdld0.fsf@gnu.org> <871uw04lr9.fsf@thinkpad.tsdh.de> <87sjog35jj.fsf@thinkpad.tsdh.de> <4E5F7ECD.9060601@swipnet.se> <838vq8e0x5.fsf@gnu.org> <87sjn03tzx.fsf@thinkpad.tsdh.de> <87sjmzbmvv.fsf@thinkpad.tsdh.de> <87vcrvm0dr.fsf@stupidchicken.com> <87aa96ogb3.fsf@thinkpad.tsdh.de> <8762ijjbzu.fsf@tsdh.uni-koblenz.de> <878vnfngjk.fsf@gnu.org> <871ut6kgm8.fsf@tsdh.uni-koblenz.de> <4EC5378C.5020500@cs.ucla.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1321549129 21001 80.91.229.12 (17 Nov 2011 16:58:49 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 17 Nov 2011 16:58:49 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 17 17:58:42 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RR5IJ-0001a0-IZ for ged-emacs-devel@m.gmane.org; Thu, 17 Nov 2011 17:58:35 +0100 Original-Received: from localhost ([::1]:52701 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RR5II-0005hW-Uw for ged-emacs-devel@m.gmane.org; Thu, 17 Nov 2011 11:58:34 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:41689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RR5IG-0005hQ-9e for emacs-devel@gnu.org; Thu, 17 Nov 2011 11:58:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RR5IE-0000UY-Nz for emacs-devel@gnu.org; Thu, 17 Nov 2011 11:58:32 -0500 Original-Received: from deliver.uni-koblenz.de ([141.26.64.15]:45789) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RR5IE-0000UT-Gj for emacs-devel@gnu.org; Thu, 17 Nov 2011 11:58:30 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by deliver.uni-koblenz.de (Postfix) with ESMTP id 2D8A9D2362; Thu, 17 Nov 2011 17:58:28 +0100 (CET) X-Virus-Scanned: amavisd-new at uni-koblenz.de Original-Received: from deliver.uni-koblenz.de ([127.0.0.1]) by localhost (deliver.uni-koblenz.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 272Z3UebKQxe; Thu, 17 Nov 2011 17:58:27 +0100 (CET) X-CHKRCPT: Envelopesender noch tassilo@member.fsf.org Original-Received: from tsdh.uni-koblenz.de (tsdh.uni-koblenz.de [141.26.67.142]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id 5C204D235E; Thu, 17 Nov 2011 17:58:27 +0100 (CET) In-Reply-To: <4EC5378C.5020500@cs.ucla.edu> (Paul Eggert's message of "Thu, 17 Nov 2011 08:34:20 -0800") User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.91 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 141.26.64.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:146081 Archived-At: Paul Eggert writes: Hi Paul, > On 11/17/11 05:45, Tassilo Horn wrote: >> +#ifdef USE_GTK >> + /* FIXME: Deleting the terminal crashes emacs because of a GTK >> + bug. See the thread starting with >> + <87d3flnxoo.fsf@thinkpad.tsdh.de> on emacs-devel. */ >> + if (terminal->type != output_x_window) >> +#endif /* USE_GTK */ >> + terminal->reference_count--; > > Could you please use a URL rather than a Message-ID? The latter is > hard for a random reader to follow. Perhaps the URL > > is what is meant? (Sorry, I can't easily tell.) Yes, the Message-ID was the top-level message of that thread, but the link you cite is actually where the important information drops in. > Also, this code would be easier to read: > > if (! (use_gtk && terminal->type == output_x_window)) > terminal->reference_count--; > > with something like this near the start of the file: > > #ifdef USE_GTK > enum { use_gtk = 1 }; > #else > enum { use_gtk = 0 }; > #endif In my opinion, it's better to keep temporary workarounds for buggy external libs as local as possible. But I don't really care, as long as it fixes the crashes. Bye, Tassilo -- (What the world needs (I think) is not (a Lisp (with fewer parentheses)) but (an English (with more.))) Brian Hayes, http://tinyurl.com/3y9l2kf