Re: Killing a frame sometimes kills emacs

[Tassilo Horn <tassilo@member.fsf.org>]

Paul Eggert <eggert@cs.ucla.edu> writes:

Hi Paul,

> On 11/17/11 05:45, Tassilo Horn wrote:
>> +#ifdef USE_GTK
>> +    /* FIXME: Deleting the terminal crashes emacs because of a GTK
>> +       bug.  See the thread starting with
>> +       <87d3flnxoo.fsf@thinkpad.tsdh.de> on emacs-devel.  */
>> +    if (terminal->type != output_x_window)
>> +#endif /* USE_GTK */
>> +      terminal->reference_count--;
>
> Could you please use a URL rather than a Message-ID?  The latter is
> hard for a random reader to follow.  Perhaps the URL
> <http://lists.gnu.org/archive/html/emacs-devel/2011-10/msg00363.html>
> is what is meant?  (Sorry, I can't easily tell.)

Yes, the Message-ID was the top-level message of that thread, but the
link you cite is actually where the important information drops in.

> Also, this code would be easier to read:
>
>     if (! (use_gtk && terminal->type == output_x_window))
>       terminal->reference_count--;
>
> with something like this near the start of the file:
>
>    #ifdef USE_GTK
>     enum { use_gtk = 1 };
>    #else
>     enum { use_gtk = 0 };
>    #endif

In my opinion, it's better to keep temporary workarounds for buggy
external libs as local as possible.  But I don't really care, as long as
it fixes the crashes.

Bye,
Tassilo
-- 
(What the world needs (I think) is not
      (a Lisp (with fewer parentheses))
      but (an English (with more.)))
Brian Hayes, http://tinyurl.com/3y9l2kf