unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@gnu.org>
To: "Jan Djärv" <jan.h.d@swipnet.se>
Cc: Geoff Gole <geoffgole@gmail.com>,
	Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: xterm.c (x_clear_frame) - commented out call to XClearWindow
Date: Tue, 22 Nov 2011 13:31:16 +0800	[thread overview]
Message-ID: <87wras4taz.fsf@gnu.org> (raw)
In-Reply-To: <391CC3E1-BEF3-4561-8902-8BEE63CDEAE7@swipnet.se> ("Jan \=\?utf-8\?Q\?Dj\=C3\=A4rv\=22's\?\= message of "Mon, 21 Nov 2011 19:02:47 +0100")

Jan Djärv <jan.h.d@swipnet.se> writes:

> The uncommented XClearWindow in x_clear_frame must be there so I
> activated it again...  Flickering is almost unavoidable for Gtk as we
> bypass the normal Gtk drawing stuff.

Obviously, I disagree.  AFAICT this has nothing to do with GTK.

The XClearWindow is obviously unnecessary if Emacs covers the entire
frame area when drawing glyph strings during redisplay, since the glyph
strings apply the background color.  The problem here arises because
there are some areas of the frame not drawn over durig redisplay,
e.g. the leftover spaces to the bottom and right in fullscreen mode.
The fact that these areas are unpainted may be regarded as a bug.  A
suitable temporary work-around would be to paint over them---but
painting the entire frame is clearly an overreach.

> Just doing
> (set-background-color "green")
>
> and then
>
> (set-background-color "white")
>
> leaves big chunks of green where there is no text unless x_clear_frame
> does its job.

I can't reproduce this at all.



  parent reply	other threads:[~2011-11-22  5:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-19  2:09 xterm.c (x_clear_frame) - commented out call to XClearWindow Geoff Gole
2011-11-21  5:15 ` Chong Yidong
2011-11-21  7:19   ` Geoff Gole
2011-11-21  8:54     ` Chong Yidong
2011-11-21 11:36       ` Geoff Gole
2011-11-21 18:02         ` Jan Djärv
2011-11-22  2:38           ` Geoff Gole
2011-11-22  5:31           ` Chong Yidong [this message]
2011-11-22  6:41             ` Jan Djärv
2011-11-22 15:37               ` Stefan Monnier
2011-11-23  6:09               ` Chong Yidong
2011-11-29 18:13                 ` Jan Djärv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wras4taz.fsf@gnu.org \
    --to=cyd@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=geoffgole@gmail.com \
    --cc=jan.h.d@swipnet.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).