From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: `add-face' Date: Fri, 07 Sep 2012 14:41:55 +0200 Message-ID: <87wr06gg30.fsf@gnus.org> References: <87harbgnez.fsf@gnus.org> <87wr06tqj9.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1347021765 3742 80.91.229.3 (7 Sep 2012 12:42:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 7 Sep 2012 12:42:45 +0000 (UTC) Cc: Wolfgang Jenkner , emacs devel To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 07 14:42:46 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T9xtT-00082M-BF for ged-emacs-devel@m.gmane.org; Fri, 07 Sep 2012 14:42:43 +0200 Original-Received: from localhost ([::1]:57551 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9xtP-0001P8-SX for ged-emacs-devel@m.gmane.org; Fri, 07 Sep 2012 08:42:39 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38770) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9xtK-0001Oo-1Y for emacs-devel@gnu.org; Fri, 07 Sep 2012 08:42:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9xtA-0005zA-Ii for emacs-devel@gnu.org; Fri, 07 Sep 2012 08:42:33 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:58418) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9xtA-0005yK-CK; Fri, 07 Sep 2012 08:42:24 -0400 Original-Received: from ip-200-13-149-91.dialup.ice.net ([91.149.13.200] helo=rusty) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1T9xsk-0003xT-7t; Fri, 07 Sep 2012 14:41:58 +0200 X-Now-Playing: Isotope 217's _The Unstable Molecule_ In-Reply-To: <87wr06tqj9.fsf@gnu.org> (Chong Yidong's message of "Fri, 07 Sep 2012 12:17:46 +0800") User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.50 (gnu/linux) X-MailScanner-ID: 1T9xsk-0003xT-7t MailScanner-NULL-Check: 1347626518.89625@cOPbFJ/faLEiH6C8PC3Owg X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153143 Archived-At: Chong Yidong writes: > As for the idea, it sounds good in principle. I think either > `add-face-text-property' or `face-add-text-property' would be a better > name. Yeah, `add-face-text-property' sounds nice. > Is it really necessary to modify `add-text-properties' to get this work, > though? It seems to me that next-single-property-change gives you > enough information to do the job without changing the internals. I was mainly thinking about speed. shr.el, for instance, adds a lot of faces, and it needs all the help it can get to speed stuff up. For larger HTML documents it's too slow now, and this more complex way of adding faces won't help. And the changes are pretty minimal, and may be generally useful. -- (domestic pets only, the antidote for overdose, milk.) http://lars.ingebrigtsen.no * Lars Magne Ingebrigtsen