unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Chong Yidong <cyd@gnu.org>
Cc: Wolfgang Jenkner <wjenkner@inode.at>, emacs devel <emacs-devel@gnu.org>
Subject: Re: `add-face'
Date: Fri, 07 Sep 2012 14:41:55 +0200	[thread overview]
Message-ID: <87wr06gg30.fsf@gnus.org> (raw)
In-Reply-To: <87wr06tqj9.fsf@gnu.org> (Chong Yidong's message of "Fri, 07 Sep 2012 12:17:46 +0800")

Chong Yidong <cyd@gnu.org> writes:

> As for the idea, it sounds good in principle.  I think either
> `add-face-text-property' or `face-add-text-property' would be a better
> name.

Yeah, `add-face-text-property' sounds nice.

> Is it really necessary to modify `add-text-properties' to get this work,
> though?  It seems to me that next-single-property-change gives you
> enough information to do the job without changing the internals.

I was mainly thinking about speed.  shr.el, for instance, adds a lot of
faces, and it needs all the help it can get to speed stuff up.  For
larger HTML documents it's too slow now, and this more complex way of
adding faces won't help.

And the changes are pretty minimal, and may be generally useful.

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Lars Magne Ingebrigtsen



  reply	other threads:[~2012-09-07 12:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-06 15:51 `add-face' Lars Ingebrigtsen
2012-09-07  4:17 ` `add-face' Chong Yidong
2012-09-07 12:41   ` Lars Ingebrigtsen [this message]
2012-09-07 13:31     ` `add-face' Chong Yidong
2012-09-07 13:46       ` `add-face' Lars Ingebrigtsen
2012-09-07 14:13         ` `add-face' Lars Ingebrigtsen
2012-09-09  6:47         ` `add-face' Chong Yidong
2012-09-09 17:31           ` `add-face' Lars Ingebrigtsen
2012-09-10  3:07             ` `add-face' Chong Yidong
2012-09-10 12:57               ` `add-face' Stefan Monnier
2012-10-24 18:56                 ` `add-face' Lars Magne Ingebrigtsen
2013-06-17  7:54                 ` `add-face' Lars Magne Ingebrigtsen
2013-06-17  9:12                   ` `add-face' Lars Magne Ingebrigtsen
2013-06-17  9:51                     ` `add-face' Lars Magne Ingebrigtsen
2013-06-17 14:43                       ` `add-face' Stefan Monnier
2013-06-17 15:29                         ` `add-face' Lars Magne Ingebrigtsen
2012-10-24 18:54               ` `add-face' Lars Magne Ingebrigtsen
2012-09-07 20:10   ` `add-face' Johan Bockgård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wr06gg30.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=cyd@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=wjenkner@inode.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).