From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.devel Subject: Re: New version of todo-mode.el (announcement + user guide) Date: Tue, 18 Jun 2013 00:33:20 +0200 Message-ID: <87wqps5pvz.fsf@rosalinde.fritz.box> References: <87k3m2275u.fsf@rosalinde.fritz.box> <8761xmxfnx.fsf@bzg.ath.cx> <87txl6ghjq.fsf@rosalinde.fritz.box> <87a9myggr7.fsf@wanadoo.es> <87sj0p8z99.fsf@rosalinde.fritz.box> <87mwqwpk98.fsf@rosalinde.fritz.box> <6emwqvxmpo.fsf@fencepost.gnu.org> <8761xjdn7t.fsf@rosalinde.fritz.box> <87txl1bula.fsf@rosalinde.fritz.box> <87obb874ru.fsf@rosalinde.fritz.box> <87y5abbkov.fsf@rosalinde.fritz.box> <87bo75brd8.fsf@rosalinde.fritz.box> <86hagwms8k.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1371508420 19599 80.91.229.3 (17 Jun 2013 22:33:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 17 Jun 2013 22:33:40 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 18 00:33:40 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UohzV-00040d-VZ for ged-emacs-devel@m.gmane.org; Tue, 18 Jun 2013 00:33:38 +0200 Original-Received: from localhost ([::1]:59795 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UohzV-0003hQ-Ap for ged-emacs-devel@m.gmane.org; Mon, 17 Jun 2013 18:33:37 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UohzL-0003Ky-Tx for emacs-devel@gnu.org; Mon, 17 Jun 2013 18:33:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UohzH-0006Vb-Q3 for emacs-devel@gnu.org; Mon, 17 Jun 2013 18:33:27 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:56513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UohzH-0006VL-Gv for emacs-devel@gnu.org; Mon, 17 Jun 2013 18:33:23 -0400 Original-Received: from mailout-de.gmx.net ([10.1.76.30]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0M2rpw-1UVNsy2qKk-00sgew for ; Tue, 18 Jun 2013 00:33:22 +0200 Original-Received: (qmail invoked by alias); 17 Jun 2013 22:33:22 -0000 Original-Received: from i59F575F1.versanet.de (EHLO rosalinde.fritz.box) [89.245.117.241] by mail.gmx.net (mp030) with SMTP; 18 Jun 2013 00:33:22 +0200 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX18ooW87ucMoze4EmKwTDPfYeg5u9znNWhZvdZPPUw s9ZRBHPQv1Kc9Q In-Reply-To: <86hagwms8k.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 17 Jun 2013 15:50:35 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 212.227.15.19 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:160533 Archived-At: On Mon, 17 Jun 2013 15:50:35 -0400 Glenn Morris wrote: > Stephen Berman wrote: > >> This works with :around advice according to my tests. Glenn, is there >> some situation where it's necessary or highly advantageous to use a >> marker to locate the diary entry? > > Don't know. It predates me. I added the other thing as a fallback for > killed buffers. At least, this is what vc-annotate tells me. Ok. Then for now I'll go with this alternative: >> Keep diary-goto-entry as it is and add the variable >> diary-goto-entry-function with default value 'diary-goto-entry, which >> other packages can override (though the overriding function will >> still have to contain the same entry locating operations). since it's least intrusive to diary-lib.el, though it means code duplication in the overriding todo-mode function. We can always decide to change it later. Steve Berman